You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to review all modules to ensure there is a way for users to set datanames in the module. Upon review, we identified two modules that require updates:
tm_g_barchart_simple
tm_g_ci
Additionally, we discussed how tm_g_ci should be designed to use x_var, y_var, and color (which are data_extract_spec objects) when defining datanames, similar to the approach described here .
Acceptance Criteria
Update the design of tm_g_barchart_simple and tm_g_ci to allow datanames to be set in the module's constructor.
Design tm_g_ci to utilize x_var, y_var, and color as data_extract_spec objects when defining datanames.
Ensure that every module provides a way to configure datanames (via argument, data extract spec, or other means) in the module's constructor.
Review and update roxygen note, if necessary.
The text was updated successfully, but these errors were encountered:
Summary
Related to insightsengineering/teal#143.
We need to review all modules to ensure there is a way for users to set
datanames
in the module. Upon review, we identified two modules that require updates:tm_g_barchart_simple
tm_g_ci
Additionally, we discussed how
tm_g_ci
should be designed to usex_var
,y_var
, andcolor
(which aredata_extract_spec
objects) when definingdatanames
, similar to the approach described here .Acceptance Criteria
tm_g_barchart_simple
andtm_g_ci
to allowdatanames
to be set in the module's constructor.tm_g_ci
to utilizex_var
,y_var
, andcolor
asdata_extract_spec
objects when definingdatanames
.datanames
(via argument, data extract spec, or other means) in the module's constructor.The text was updated successfully, but these errors were encountered: