Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove set_datanames functionality #1436

Open
donyunardi opened this issue Dec 19, 2024 · 0 comments
Open

Remove set_datanames functionality #1436

donyunardi opened this issue Dec 19, 2024 · 0 comments
Labels

Comments

@donyunardi
Copy link
Contributor

donyunardi commented Dec 19, 2024

Continuation of #1380 (comment)

Summary

We will remove the set_datanames functionality from the codebase and update a handful of teal modules to ensure users can control the module's datanames from the module's constructor.

While most modules include an argument (or equivalent to it) to configure datanames, some do not:
image

Definition of Done

  • Remove the set_datanames feature from the codebase, including related unit tests and associated components.
  • Allow users to set datanames in the module's constructor in teal.modules.general.
  • Allow users to set datanames in the module's constructor in teal.modules.clinical.

We have identified the teal modules affected in teal.modules.general (TMG) and teal.modules.clinical (TMC), and we will open issues for these modules.

Our priority will be to address the modules in tmc and tmg first. Other non-CRAN-released teal modules, such as teal.osprey and teal.goshawk, will be addressed at a later stage.

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant