Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

317 log shiny input changes #318

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 10, 2024

Closes #317

Tested with ?tm_g_gh_boxplot.

Output of what was registered in changes

image

@m7pr m7pr added the core label Oct 10, 2024
@m7pr m7pr requested a review from donyunardi October 10, 2024 12:07
Copy link
Contributor

github-actions bot commented Oct 10, 2024

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        349     349  0.00%    175-592
R/tm_g_gh_correlationplot.R                556     556  0.00%    227-892
R/tm_g_gh_density_distribution_plot.R      274     274  0.00%    135-461
R/tm_g_gh_lineplot.R                       562     562  0.00%    161-818
R/tm_g_gh_scatterplot.R                    246     246  0.00%    144-443
R/tm_g_gh_spaghettiplot.R                  316     316  0.00%    194-593
R/toggleable_slider.R                      158     158  0.00%    73-248
R/utils-arbitrary_lines.r                  125     125  0.00%    19-176
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         29      29  0.00%    9-45
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          66      66  0.00%    2-98
R/utils.R                                   49      49  0.00%    12-112
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2931    2931  0.00%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                         +1      +1  +100.00%
R/tm_g_gh_correlationplot.R                 +1      +1  +100.00%
R/tm_g_gh_density_distribution_plot.R       +1      +1  +100.00%
R/tm_g_gh_lineplot.R                        +1      +1  +100.00%
R/tm_g_gh_scatterplot.R                     +1      +1  +100.00%
R/tm_g_gh_spaghettiplot.R                   +1      +1  +100.00%
TOTAL                                       +6      +6  +100.00%

Results for commit: d9bd063

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm comparing the update that we did here with the previous PR:
https://github.com/insightsengineering/teal.goshawk/pull/298/files

Should we include the log_shiny_input_changes in toggle_slider_server and srv_arbitrary_lines too like we did previously?

@m7pr
Copy link
Contributor Author

m7pr commented Oct 11, 2024

@donyunardi no, it's not needed. Did you run the app on your own and verified that you see logs or not?

I can see logs for the toggle slider
image

You see those changes logged because it is used in other modules, which use log_shiny_input_changes in their sever

Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to understand the differences between the two PR updates since they're related, in case I missed something.

I ran a couple of plots and saw the log changes for the sliders and the arbitrary line.

LGTM

@donyunardi donyunardi merged commit 5b0d7e7 into main Oct 11, 2024
28 checks passed
@donyunardi donyunardi deleted the 317_log_shiny_input_changes@main branch October 11, 2024 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Introduce teal.logger::log_shiny_input_changes
2 participants