Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

239 utilize logger::log_shiny_input_change #274

Merged
merged 7 commits into from
May 16, 2024
Merged

239 utilize logger::log_shiny_input_change #274

merged 7 commits into from
May 16, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented May 9, 2024

@m7pr m7pr added the core label May 9, 2024
@m7pr m7pr requested a review from pawelru May 9, 2024 10:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        353     353  0.00%    175-595
R/tm_g_gh_correlationplot.R                564     564  0.00%    227-898
R/tm_g_gh_density_distribution_plot.R      279     279  0.00%    135-464
R/tm_g_gh_lineplot.R                       549     549  0.00%    159-792
R/tm_g_gh_scatterplot.R                    246     246  0.00%    144-442
R/tm_g_gh_spaghettiplot.R                  298     298  0.00%    192-557
R/toggleable_slider.R                      155     155  0.00%    72-244
R/utils-arbitrary_lines.r                  126     126  0.00%    19-176
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   39      39  0.00%    12-83
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2881    2881  0.00%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                         +1      +1  +100.00%
R/tm_g_gh_correlationplot.R                 +1      +1  +100.00%
R/tm_g_gh_density_distribution_plot.R       +1      +1  +100.00%
R/tm_g_gh_lineplot.R                        +1      +1  +100.00%
R/tm_g_gh_scatterplot.R                     +1      +1  +100.00%
R/tm_g_gh_spaghettiplot.R                   +1      +1  +100.00%
R/toggleable_slider.R                       +1      +1  +100.00%
R/utils-arbitrary_lines.r                   +1      +1  +100.00%
TOTAL                                       +8      +8  +100.00%

Results for commit: a9e5a05

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr mentioned this pull request May 13, 2024
Merged
@m7pr m7pr mentioned this pull request May 16, 2024
Closed
@m7pr
Copy link
Contributor Author

m7pr commented May 16, 2024

Created an issue, for the future, to keep in mind that the if statement might not be needed anymore at some point #275

@m7pr m7pr merged commit 1df9181 into main May 16, 2024
28 checks passed
@m7pr m7pr deleted the 239_log_shiny_input_change@main branch May 16, 2024 10:59
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelru pawelru pawelru approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m7pr @pawelru