Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1176 remove Show Warnings from modules #273

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented May 8, 2024

@m7pr m7pr added the core label May 8, 2024
@m7pr m7pr requested a review from pawelru May 8, 2024 10:44
Copy link
Contributor

github-actions bot commented May 8, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@m7pr
Copy link
Contributor Author

m7pr commented May 8, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented May 8, 2024

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        352     352  0.00%    175-594
R/tm_g_gh_correlationplot.R                563     563  0.00%    227-897
R/tm_g_gh_density_distribution_plot.R      278     278  0.00%    135-463
R/tm_g_gh_lineplot.R                       548     548  0.00%    159-791
R/tm_g_gh_scatterplot.R                    245     245  0.00%    144-441
R/tm_g_gh_spaghettiplot.R                  297     297  0.00%    192-556
R/toggleable_slider.R                      154     154  0.00%    72-243
R/utils-arbitrary_lines.r                  125     125  0.00%    19-175
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   39      39  0.00%    12-83
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2873    2873  0.00%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                         -7      -7  +100.00%
R/tm_g_gh_correlationplot.R                 -7      -7  +100.00%
R/tm_g_gh_density_distribution_plot.R       -7      -7  +100.00%
R/tm_g_gh_lineplot.R                        -7      -7  +100.00%
R/tm_g_gh_scatterplot.R                     -7      -7  +100.00%
R/tm_g_gh_spaghettiplot.R                   -7      -7  +100.00%
TOTAL                                      -42     -42  +100.00%

Results for commit: 546391f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! no more occurrence of teal.code::get_warnings(). Could you please add a news entry for this?

@m7pr m7pr enabled auto-merge (squash) May 10, 2024 08:53
@m7pr m7pr merged commit b583826 into main May 10, 2024
25 checks passed
@m7pr m7pr deleted the 1176_remove_show_warnings@main branch May 10, 2024 08:57
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants