Handle delayed choices

[vedhav]

Closes #255

Fixes the modules to get delayed choices:

• tm_g_gh_boxplot
• tm_g_gh_correlationplot
• tm_g_gh_density_distribution_plot
• tm_g_gh_lineplot
• tm_g_gh_scatterplot
• tm_g_gh_spaghettiplot

[vedhav]

@gogonzo Before I went ahead and implemented this fix for all the modules I wanted to check with you if this is the best solution we have for this. I was not so sure about doing it this way.

[github-actions]

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        359     359  0.00%    172-599
R/tm_g_gh_correlationplot.R                570     570  0.00%    222-900
R/tm_g_gh_density_distribution_plot.R      285     285  0.00%    134-470
R/tm_g_gh_lineplot.R                       576     576  0.00%    160-833
R/tm_g_gh_scatterplot.R                    252     252  0.00%    142-447
R/tm_g_gh_spaghettiplot.R                  304     304  0.00%    189-561
R/toggleable_slider.R                      154     154  0.00%    82-253
R/utils-arbitrary_lines.r                  125     125  0.00%    19-175
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    25-37
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   39      39  0.00%    12-83
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2935    2935  0.00%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                         +8      +8  +100.00%
R/tm_g_gh_correlationplot.R                +13     +13  +100.00%
R/tm_g_gh_density_distribution_plot.R      +10     +10  +100.00%
R/tm_g_gh_lineplot.R                       +12     +12  +100.00%
R/tm_g_gh_scatterplot.R                    +12     +12  +100.00%
R/tm_g_gh_spaghettiplot.R                  +12     +12  +100.00%
TOTAL                                      +67     +67  +100.00%

Results for commit: b146d0d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[m7pr]

Hey @vedhav would you be able to summarize the current state of this PR?

[vedhav]

It's ready to review and merge. The test would be to check if you can run the examples listed in the issue on main and reproduce the error which will go away when you checkout to this branch.
This issue was observed in tmc earlier and the root cause of this issue was that the delayed logic from the modules was moved to teal.transform but, looks like there were some inputs which was breaking the modules when delayed_data was being passed.

[vedhav]

The fix was to use the teal.transform::resolve_delayed and convert these delayed data into spec and choices values.

[m7pr]

Alrighty, thanks for the update. Taking a look now

[m7pr]

Hey, this branch fixed the issue for tm_g_gh_boxplot (I run the code from #255 (comment)) .

Can you potentially share example app with other modules using delayed_choices?

[m7pr]

Ok, I will test the whole longititudinal app run locally on my machine, but built from this branch https://github.com/insightsengineering/teal.gallery/blob/main/longitudinal/app.R

[m7pr]

Hey @vedhav when I run teal.gallery app (on dev branch) called longitudinal on teal.goshawk from this branch I get error for Visualizations -> Line Plot tab. Everything else is smooth besides Variable Browser but I get it's out of scope of this issue.

Line Plot

Listening on http://127.0.0.1:7618
[INFO] 2024-02-13 16:17:03.5299 pid:6356 token:[dff910ff] teal Initializing reporter_previewer_module
Warning: The 'plotly_relayout' event tied a source ID of 'teal-main_ui-filter_panel-active-ADSL-filter-ADSL_AGE-inputs-histogram_plot' is not registered. In order to obtain this event data, please add `event_register(p, 'plotly_relayout')` to the plot (`p`) that you wish to obtain event data from.
Warning: Error in [[: subscript out of bounds
  168: <Anonymous>
  167: FUN [C:/Rprojects/teal.goshawk/R/tm_g_gh_lineplot.R#523]
  166: vapply
  164: <reactive> [C:/Rprojects/teal.goshawk/R/tm_g_gh_lineplot.R#518]
  148: line_type_selected
  141: <reactive> [C:/Rprojects/teal.goshawk/R/tm_g_gh_lineplot.R#679]
  125: plot_q
  124: <reactive>
  108: plot_r
   99: renderUI
   98: func
   85: renderFunc
   84: output$teal-main_ui-root-visualizations-Line_Plot-module-plot-plot_out_main
    3: runApp
    2: print.shiny.appobj
    1: <Anonymous>
Warning: Error in [[: subscript out of bounds
  3: runApp
  2: print.shiny.appobj
  1: <Anonymous>

Variable Browser

[vedhav]

Thanks for testing. I think it's a new bug that has popped up as Variable Browser comes from tmg. I'll have a deeper look and create a relevant issue on GitHub.

[m7pr]

Let me know when you will fix teal.gallery on dev and I'll pull and review again. Thanks!

[vedhav]

@m7pr This PR will fix the issue. Looks like it was broken for a long time. Not sure how we missed it.

[m7pr]

Alrighty, so this issue is fixed, and the other one (new one) that arrised is discussed in another thread. You are good to merge, when you fix the R CMD CHECK failing.