Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

216 update teal.code version in dependencies #224

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jul 11, 2023

Closes #216

qenv replaced chunks in this PR https://github.com/insightsengineering/teal.goshawk/pull/203/files - this is a backend change and this was not exposed in vignettes and not exposed in examples. I reviewed examples and vignettes in the last 2 weeks while working on #223 and #221 and I run those examples multiple times recently. Most of the things marked in #216 were not needed to be checked, besides the teal.code version bump.

@m7pr m7pr added documentation Improvements or additions to documentation core labels Jul 11, 2023
@m7pr m7pr requested a review from gogonzo July 11, 2023 14:37
@m7pr m7pr marked this pull request as ready for review July 11, 2023 14:37
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        349     349  0.00%    216-632
R/tm_g_gh_correlationplot.R                552     552  0.00%    282-940
R/tm_g_gh_density_distribution_plot.R      274     274  0.00%    161-484
R/tm_g_gh_lineplot.R                       559     559  0.00%    184-837
R/tm_g_gh_scatterplot.R                    235     235  0.00%    167-453
R/tm_g_gh_spaghettiplot.R                  284     284  0.00%    227-577
R/toggleable_slider.R                      154     154  0.00%    82-253
R/utils-arbitrary_lines.r                  121     121  0.00%    19-172
R/utils-data_constraints.r                 186     186  0.00%    2-255
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    25-37
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   17      17  0.00%    12-32
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2812    2812  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: bce1837

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m7pr m7pr enabled auto-merge (squash) July 12, 2023 10:31
@m7pr m7pr merged commit 04bee95 into main Jul 12, 2023
@m7pr m7pr deleted the 216_documentation_qenv_review@main branch July 12, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review tgoshawk documentation before release
2 participants