553 change level in log_shiny_input_changes and exclude plot sizes …

…in logging (#281)

Part of insightsengineering/coredev-tasks#553
and insightsengineering/coredev-tasks#568

.pre-commit-config.yaml

@@ -28,7 +28,6 @@ repos:
           - ggplot2
           - grDevices
           - lifecycle
-          - logger
           - methods
           - rlang
           - shinyjs

DESCRIPTION

@@ -42,14 +42,13 @@ Imports:
     ggplot2 (>= 3.4.0),
     grDevices,
     lifecycle (>= 0.2.0),
-    logger (>= 0.3.0),
     methods,
     rlang (>= 1.0.0),
     shinyjs,
     shinyvalidate,
     stats,
     teal.code (>= 0.4.1.9009),
-    teal.logger (>= 0.1.3.9013),
+    teal.logger (>= 0.2.0.9004),
     teal.reporter (>= 0.2.0),
     teal.widgets (>= 0.4.0),
     tidyr (>= 0.8.3)
@@ -67,7 +66,7 @@ VignetteBuilder:
 Config/Needs/verdepcheck: insightsengineering/goshawk, rstudio/shiny,
     insightsengineering/teal, insightsengineering/teal.transform,
     mllg/checkmate, daattali/colourpicker, tidyverse/dplyr, rstudio/DT,
-    tidyverse/ggplot2, r-lib/lifecycle, daroczig/logger, r-lib/rlang,
+    tidyverse/ggplot2, r-lib/lifecycle, r-lib/rlang,
     daattali/shinyjs, rstudio/shinyvalidate,
     insightsengineering/teal.code, insightsengineering/teal.logger,
     insightsengineering/teal.reporter, insightsengineering/teal.widgets,

NEWS.md

@@ -6,7 +6,7 @@
 * Adapted all modules to use `teal_data` objects.
 
 ### Enhancements
-* Added `logger` functionality for logging changes in shiny inputs in all modules. `logger` was added to Imports.
+* Added `teal.logger` functionality for logging changes in shiny inputs in all modules.
 * Updated the documentation and vignettes to demonstrate method to pass `teal_data` object to `teal::init()`.
 
 ### Miscellaneous

R/tm_g_gh_boxplot.R

@@ -326,7 +326,7 @@ srv_g_boxplot <- function(id,
   checkmate::assert_class(shiny::isolate(data()), "teal_data")
 
   moduleServer(id, function(input, output, session) {
-    if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
+    teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
     output$axis_selections <- renderUI({
       env <- shiny::isolate(as.list(data()@env))
       resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env)

R/tm_g_gh_correlationplot.R

@@ -382,7 +382,7 @@ srv_g_correlationplot <- function(id,
   checkmate::assert_class(shiny::isolate(data()), "teal_data")
 
   moduleServer(id, function(input, output, session) {
-    if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
+    teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
     output$axis_selections <- renderUI({
       env <- shiny::isolate(as.list(data()@env))
       resolved_x_param <- teal.transform::resolve_delayed(module_args$xaxis_param, env)

R/tm_g_gh_density_distribution_plot.R

@@ -268,7 +268,7 @@ srv_g_density_distribution_plot <- function(id, # nolint
   checkmate::assert_class(shiny::isolate(data()), "teal_data")
 
   moduleServer(id, function(input, output, session) {
-    if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
+    teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
     output$axis_selections <- renderUI({
       env <- shiny::isolate(as.list(data()@env))
       resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env)

R/tm_g_gh_lineplot.R

@@ -356,7 +356,7 @@ srv_lineplot <- function(id,
   checkmate::assert_class(shiny::isolate(data()), "teal_data")
 
   moduleServer(id, function(input, output, session) {
-    if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
+    teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
     ns <- session$ns
 
     output$axis_selections <- renderUI({

R/tm_g_gh_scatterplot.R

@@ -267,7 +267,7 @@ srv_g_scatterplot <- function(id,
   checkmate::assert_class(shiny::isolate(data()), "teal_data")
 
   moduleServer(id, function(input, output, session) {
-    if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
+    teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
     output$axis_selections <- renderUI({
       env <- shiny::isolate(as.list(data()@env))
       resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env)

R/tm_g_gh_spaghettiplot.R

@@ -376,7 +376,7 @@ srv_g_spaghettiplot <- function(id,
   checkmate::assert_class(shiny::isolate(data()), "teal_data")
 
   moduleServer(id, function(input, output, session) {
-    if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
+    teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
     output$axis_selections <- renderUI({
       env <- shiny::isolate(as.list(data()@env))
       resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env)

R/toggleable_slider.R

@@ -142,7 +142,7 @@ toggle_slider_ui <- function(id,
 # is_dichotomous_slider `logical` whether it is a dichotomous slider or normal slider
 toggle_slider_server <- function(id, is_dichotomous_slider = TRUE) {
   moduleServer(id, function(input, output, session) {
-    if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
+    teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
     checkmate::assert_flag(is_dichotomous_slider)
     # model view controller: cur_state is the model, the sliderInput and numericInputs are two views/controllers
     # additionally, the module returns the cur_state, so it can be controlled from that end as well

R/utils-arbitrary_lines.r

@@ -48,7 +48,7 @@ ui_arbitrary_lines <- function(id, line_arb, line_arb_label, line_arb_color, tit
 #' @keywords internal
 srv_arbitrary_lines <- function(id) {
   moduleServer(id, function(input, output, session) {
-    if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
+    teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
     comma_sep_to_values <- function(values, wrapper_fun = trimws) {
       vals <- strsplit(values, "\\s{0,},\\s{0,}")[[1]]
       suppressWarnings(wrapper_fun(vals))