Skip to content

Commit

Permalink
Install teal.slice with the bslib fix for stable app deployments (#110
Browse files Browse the repository at this point in the history
)

All the GitHub packages are installed using the latest tag. But the
latest tagged version of `teal.slice` breaks the apps because it's [not
compatible](insightsengineering/teal.slice@ac790e4)
with the bslib's latest tagged version 0.6.0.
The fix for this was made only in teal.slice v0.4.0.9023 so unless we
create a tagged version of `teal.slice` with this fix we want to install
this version by force.

---------

Signed-off-by: Vedha Viyash <[email protected]>
  • Loading branch information
vedhav authored Nov 28, 2023
1 parent e047033 commit d19a0ba
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,12 @@ jobs:
pkg_name_structure <- ifelse("${{ matrix.channel }}" == "stable", "%s/%s@*release", "%s/%s")
for (package in lockfile$Packages) {
if (package$Source == "GitHub") {
renv::record(sprintf(pkg_name_structure, package$RemoteUsername, package$Package))
# TODO: After teal.slice is released we have to remove this change. This workaround is because update to {bslib} breaks current release of teal.slice
if (package$Package == "teal.slice" && "${{ matrix.channel }}" == "stable") {
renv::record("insightsengineering/teal.slice@103491c67e26a9a85d636bd105a806904a0111ec")
} else {
renv::record(sprintf(pkg_name_structure, package$RemoteUsername, package$Package))
}
}
}
Expand Down

0 comments on commit d19a0ba

Please sign in to comment.