Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update testthat version #359

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

donyunardi
Copy link
Contributor

@donyunardi donyunardi commented Jan 3, 2025

We need to bump up testthat version because we're using testthat::it function in unit tests.

This function was introduced in 3.1.8:
https://github.com/r-lib/testthat/blob/v3.1.8/R/describe.R#L89

This update will fix the Dependency Test - min isolated:
https://github.com/insightsengineering/teal.data/actions/runs/12532231366/job/34950746107#step:9:774

@donyunardi donyunardi added the core label Jan 3, 2025
@donyunardi
Copy link
Contributor Author

Got another failure about compare_proxy which seems to be related to waldo package:
https://github.com/insightsengineering/teal.data/actions/runs/12605104075/job/35133232553#step:9:235

Updating testthat to 3.2.0

@donyunardi
Copy link
Contributor Author

Still fails:
https://github.com/insightsengineering/teal.data/actions/runs/12605422042/job/35134030219#step:9:853

This may have something to do with the default_cdisc_join_keys object.

@donyunardi
Copy link
Contributor Author

Issue still persist. I think it may have something to do with other dependencies based on the min_isolated strategy.

@averissimo @m7pr
Any chance you can shed a light on this based on your experience working with verdepcheck?
For sure we need to update the testthat version to 3.1.8 but not sure how to address this compare_proxy issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant