-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TealData and check argument #349
Conversation
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
Code Coverage Summary
Diff against main
Results for commit: d7780ee Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 15 suites 1s ⏱️ Results for commit d7780ee. ♻️ This comment has been updated with latest results. |
Thanks @llrs-roche I will review on Monday |
Hey @llrs-roche so many functions were removed. Can you update |
@llrs-roche some things got merge to the main branch, now you have conflicts with the main branch. Would you be able to resolve conflicts locally and push? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, left a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PR addressing all the comments. I included a brief point in NEWS.md too.
Unit Test Performance Difference
Additional test case details
Results for commit 20d8e21 ♻️ This comment has been updated with latest results. |
Co-authored-by: Marcin <[email protected]> Signed-off-by: Lluís Revilla <[email protected]>
Pull Request
Fixes #344
The first commit is to deal with TealData and connectors: code and documentation removed.
The second commit is to deal with
check
argument: I've kept the documentation ofverify()
all the other related code and documentation has been removed.All these functions already had
deprecate_stop
so they would have caused an error on calling them and they have been so for ~1year so I think directly removing them is fine.Local check (with teal.code 0.5.0.9013 ) doesn't raise warnings, errors or notes.