Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TealData and check argument #349

Merged
merged 11 commits into from
Nov 11, 2024
Merged

Conversation

llrs-roche
Copy link
Contributor

Pull Request

Fixes #344

The first commit is to deal with TealData and connectors: code and documentation removed.
The second commit is to deal with check argument: I've kept the documentation of verify() all the other related code and documentation has been removed.

All these functions already had deprecate_stop so they would have caused an error on calling them and they have been so for ~1year so I think directly removing them is fine.
Local check (with teal.code 0.5.0.9013 ) doesn't raise warnings, errors or notes.

@llrs-roche llrs-roche added the core label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@llrs-roche
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented Nov 8, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  -------------------
R/cdisc_data.R                   1       0  100.00%
R/deprecated.R                  14       0  100.00%
R/dummy_function.R               2       2  0.00%    14-15
R/formatters_var_labels.R       61       0  100.00%
R/join_key.R                    38       0  100.00%
R/join_keys-c.R                 12       0  100.00%
R/join_keys-extract.R          128       0  100.00%
R/join_keys-names.R             15       0  100.00%
R/join_keys-parents.R           30       0  100.00%
R/join_keys-print.R             45       0  100.00%
R/join_keys-utils.R             73       3  95.89%   35-38
R/join_keys.R                   21       0  100.00%
R/teal_data-class.R             35       4  88.57%   71, 119-121
R/teal_data-constructor.R       11       2  81.82%   31, 35
R/teal_data-extract.R            3       0  100.00%
R/teal_data-get_code.R          13       8  38.46%   114-120, 124
R/teal_data-names.R              8       1  87.50%   31
R/teal_data-show.R               4       4  0.00%    14-19
R/testhat-helpers.R             26       0  100.00%
R/topological_sort.R            32       0  100.00%
R/verify.R                      42      11  73.81%   67, 97-101, 104-108
TOTAL                          614      35  94.30%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  -------
R/deprecated.R                 -57     -57  +80.28%
R/teal_data-constructor.R      -20     -14  +33.43%
TOTAL                          -77     -71  +9.64%

Results for commit: d7780ee

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Unit Tests Summary

  1 files   15 suites   1s ⏱️
163 tests 163 ✅ 0 💤 0 ❌
218 runs  218 ✅ 0 💤 0 ❌

Results for commit d7780ee.

♻️ This comment has been updated with latest results.

@m7pr m7pr self-assigned this Nov 8, 2024
@m7pr
Copy link
Contributor

m7pr commented Nov 8, 2024

Thanks @llrs-roche I will review on Monday

@m7pr
Copy link
Contributor

m7pr commented Nov 11, 2024

Hey @llrs-roche so many functions were removed. Can you update NEWS.md with a note about it?

@m7pr
Copy link
Contributor

m7pr commented Nov 11, 2024

@llrs-roche some things got merge to the main branch, now you have conflicts with the main branch. Would you be able to resolve conflicts locally and push?

R/deprecated.R Outdated Show resolved Hide resolved
R/teal_data.R Outdated Show resolved Hide resolved
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, left a couple of comments

Copy link
Contributor Author

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR addressing all the comments. I included a brief point in NEWS.md too.

R/deprecated.R Outdated Show resolved Hide resolved
R/teal_data.R Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
deprecated 💀 $0.10$ $-0.10$ $-2$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
deprecated 💀 $0.01$ $-0.01$ getter_returns_same_as_names_
deprecated 💀 $0.08$ $-0.08$ setter_does_nothing_to_object

Results for commit 20d8e21

♻️ This comment has been updated with latest results.

NEWS.md Outdated Show resolved Hide resolved
R/deprecated.R Show resolved Hide resolved
@llrs-roche llrs-roche enabled auto-merge (squash) November 11, 2024 13:48
@llrs-roche llrs-roche merged commit ce21695 into main Nov 11, 2024
29 checks passed
@llrs-roche llrs-roche deleted the 344_remove_deprecated@main branch November 11, 2024 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Deprecated Functions
2 participants