Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove verify-warning from the code #334

Merged
merged 3 commits into from
Sep 26, 2024
Merged

remove verify-warning from the code #334

merged 3 commits into from
Sep 26, 2024

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Sep 26, 2024

linking to the discussion
insightsengineering/teal#1342 (comment)

  • removed verification-warning message from get_code
  • added is_verified method to possibly handle @verified == FALSE by external process. I'm fine to use @verified directly in teal - I'm happy also to remove is_verified if suggested in review.

- introduce is_verified to possibly handle unvalidated objects
Copy link
Contributor

github-actions bot commented Sep 26, 2024

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  --------------------
R/cdisc_data.R                       1       0  100.00%
R/deprecated.R                      57      57  0.00%    19-344
R/dummy_function.R                   2       2  0.00%    14-15
R/formatters_var_labels.R           61       0  100.00%
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   35-38
R/join_keys.R                       22       0  100.00%
R/teal_data-class.R                 26       1  96.15%   69
R/teal_data-datanames.R             20       0  100.00%
R/teal_data-get_code.R              12       0  100.00%
R/teal_data-show.R                   4       4  0.00%    14-19
R/teal_data.R                       30      16  46.67%   33, 36-42, 52-58, 61
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      187       1  99.47%   282
R/verify.R                          42      11  73.81%   65, 95-99, 102-106
TOTAL                              863      95  88.99%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  --------
R/teal_data-get_code.R       -2       0  +100.00%
TOTAL                        -2       0  -0.03%

Results for commit: 22038eb

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Unit Tests Summary

  1 files   14 suites   2s ⏱️
203 tests 201 ✅ 2 💤 0 ❌
276 runs  274 ✅ 2 💤 0 ❌

Results for commit 22038eb.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo merged commit bd19dea into main Sep 26, 2024
28 checks passed
@gogonzo gogonzo deleted the 1298_raw_datanames@main branch September 26, 2024 12:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants