Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix order #306

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix order #306

merged 2 commits into from
Apr 4, 2024

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Apr 3, 2024

Fix order of returned lines

Copy link
Contributor

github-actions bot commented Apr 3, 2024

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  --------------------
R/cdisc_data.R                       1       0  100.00%
R/deprecated.R                      57      57  0.00%    19-344
R/dummy_function.R                   2       2  0.00%    14-15
R/formatters_var_labels.R           61       0  100.00%
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   35-38
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   69
R/teal_data-datanames.R             10       0  100.00%
R/teal_data-get_code.R              14       0  100.00%
R/teal_data-show.R                   4       4  0.00%    14-19
R/teal_data.R                       30      16  46.67%   33, 36-42, 52-58, 61
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      184       1  99.46%   275
R/verify.R                          42      11  73.81%   65, 95-99, 102-106
TOTAL                              850      95  88.82%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d227c99

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Unit Tests Summary

  1 files   14 suites   2s ⏱️
193 tests 191 ✅ 2 💤 0 ❌
265 runs  263 ✅ 2 💤 0 ❌

Results for commit d227c99.

♻️ This comment has been updated with latest results.

@kartikeyakirar kartikeyakirar self-assigned this Apr 3, 2024
Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Tested on simple example.


tdata <- teal_data(x1 = iris, x2 = mtcars,
                   code = "x1 <- iris
                   x2 <- mtcars
                   x1 <- x1[1:10,]")

get_code(tdata, datanames = c("x1", "x2"))

before:
"x1 <- iris" "x1 <- x1[1:10, ]" "x2 <- mtcars"

after:
"x1 <- iris" "x2 <- mtcars" "x1 <- x1[1:10, ]"

@gogonzo gogonzo enabled auto-merge (squash) April 4, 2024 05:43
@gogonzo gogonzo merged commit 7bca106 into main Apr 4, 2024
23 checks passed
@gogonzo gogonzo deleted the fix_order branch April 4, 2024 05:44
@donyunardi donyunardi mentioned this pull request Apr 29, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants