Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip vbump] upversion to 0.4.0 #280

Merged
merged 11 commits into from
Feb 1, 2024
Merged

[skip vbump] upversion to 0.4.0 #280

merged 11 commits into from
Feb 1, 2024

Conversation

donyunardi
Copy link
Contributor

Related with #226

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  --------------------
R/cdisc_data.R                       1       0  100.00%
R/deprecated.R                      57      57  0.00%    19-344
R/dummy_function.R                   2       2  0.00%    14-15
R/formatters_var_labels.R           36      11  69.44%   60, 69-80
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   35-38
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   69
R/teal_data-datanames.R             10       0  100.00%
R/teal_data-get_code.R              14       0  100.00%
R/teal_data-show.R                   4       4  0.00%    14-19
R/teal_data.R                       30      16  46.67%   34, 37-43, 53-59, 62
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      166       1  99.40%   258
R/verify.R                          42      11  73.81%   63, 93-97, 100-104
TOTAL                              807     106  86.86%

Diff against main

Filename          Stmts    Miss  Cover
--------------  -------  ------  --------
R/cdisc_data.R        0      -1  +100.00%
R/teal_data.R        +8      +7  -12.42%
TOTAL                +8      +6  +1.62%

Results for commit: 75d07c2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024 •
edited
Loading

Unit Tests Summary

  1 files   14 suites   1s ⏱️
175 tests 173 ✅ 2 💤 0 ❌
244 runs  242 ✅ 2 💤 0 ❌

Results for commit 75d07c2.

♻️ This comment has been updated with latest results.

@gogonzo
deprecate check (#282)
141251e 
Deprecate `check` argument
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
cdisc_data 💀 $0.06$ $-0.06$ cdisc_data_returns_teal_data_object_for_objects_different_than_old_api
cdisc_data 👶 $+0.09$ cdisc_data_returns_teal_data_object_with_default_join_keys_for_given_dataset

Results for commit 643fd6b

♻️ This comment has been updated with latest results.

gogonzo and others added 9 commits January 25, 2024 09:30
@gogonzo
orcid DK
ed0b19c
@averissimo
orcid AV
7f3e1a7
add ORCID for AC
eeb767b
update WORDLIST
a31d630
@dependabot-preview
[skip actions] Roxygen Man Pages Auto Update
70e1714
@gogonzo
restart cicd
7052a1b
@averissimo
Response to comments from CRAN 0.4.0-rc2 (#284)
1512f1b 
Closes #283

#### Changes description

- [x] Proposes a new description
- [ ] Remove/adress `@examples` of non-exported functions

#### Here are a few alternatives

1. Utilities to provide a unified data model for `teal` applications
focusing on reproducibility and relational data.
    
1. Utilities to provide a unified data model for `teal` applications
focusing on reproducibility. The model and data transformation functions
support a wide range of data structures, such as `data.frame`,
`MultiAssayExperiment`, matrices and others. Relationships between
datasets can be modelled using `join_keys` function.
1. Utilities to provide a unified data model for `teal` applications
focusing on reproducibility that supports a wide range of data
structures, such as `data.frame`, `MultiAssayExperiment`, matrices and
others.
1. Utilities to provide a unified data model for `teal` applications
focusing on reproducibility. `teal.data` supports a wide range of data
structures, such as `data.frame`, `MultiAssayExperiment` and matrices.
1. With a core focus on reproducibility, these utilities provide a
unified data model for teal applications, supporting a diverse range of
data structures such as `data.frame`, `MultiAssayExperiment`, matrices,
and others.
1. Utilities to provide a unified data model for `teal` applications
focusing on reproducibility and relational data.
@averissimo @gogonzo
Moves default_cdisc_join_keys to data folder (#285)
b814945 
Co-authored-by: go_gonzo <[email protected]>
@gogonzo
remove back ticks from description
75d07c2
@vedhav vedhav self-requested a review February 1, 2024 05:46
vedhav
vedhav approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@donyunardi
Copy link
Contributor Author

teal.data now in cran:
https://cran.r-project.org/web/packages/teal.data/index.html

@donyunardi donyunardi merged commit 7106fa8 into main Feb 1, 2024
24 checks passed
@donyunardi donyunardi deleted the release-candidate-v0.4.0 branch February 1, 2024 05:50
@vedhav
Copy link
Contributor

vedhav commented Feb 1, 2024

I think we talked about reverting the examples commit after the cran release.

@donyunardi
Copy link
Contributor Author

donyunardi commented Feb 1, 2024 •
edited
Loading

I don't see any commit where examples being removed for teal.data.
Do you see any?

@vedhav vedhav restored the release-candidate-v0.4.0 branch February 1, 2024 07:17
@vedhav vedhav deleted the release-candidate-v0.4.0 branch February 1, 2024 07:23
@averissimo
Copy link
Contributor

teal.data does not have these internal examples.

teal.slice does.

@vedhav
Copy link
Contributor

vedhav commented Feb 1, 2024

Oh, thank god. I was unable to find them anywhere :D

@chlebowa
Copy link
Contributor

chlebowa commented Feb 1, 2024

Sorry, my mistake. I must have misunderstood the response to our initial submission.

In teal.code the examples with getFromNamespace were added when the package was already on CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedhav vedhav vedhav approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@donyunardi @vedhav @averissimo @chlebowa @gogonzo