-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
251 update vignettes@main #276
Conversation
Code Coverage Summary
Diff against main
Results for commit: dc51bbe Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 14 suites 1s ⏱️ Results for commit dc51bbe. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, those 2 vignettes cover a lot of basic and advanced usage. They are both complement each other in a way where each focus on specific details, but they both created a whole full picture of teal_data object and it's typical ways of using it. Great job explaining that. If only all the software in the world had such thoroughly written documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wunderbar 💪
Co-authored-by: Vedha Viyash <[email protected]> Signed-off-by: Aleksander Chlebowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
1 minor comment that shouldn't block the merge.
ps. just like @m7pr said, it would be nice if all documentation was this good
Closes #251