Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tdata in tealdata@main #138
Tdata in tealdata@main #138
Changes from all commits
7782175
39a58ad
3b373d1
711457c
aaf0e0e
c83263b
1978ffa
4e1bbe1
f7798a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
check
argument here is not in its perfect place and is only passed downstream insideFilteredData
to be called inteal::get_datasets_code
to evaluate if an warning message should be returned in the SRC or not.An alternative to this would be not to pass
check
at all but rather to evaluate ifcheck
is TRUE or FALSE upstream and throw a warning message in the console. This will not return a warnings message in the SRC as it is done now but will avoid us the passing an unnecessary argument all through the teal app setup.@nikolas-burkoff @donyunardi @lcd2yyz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me the home for this is
R/get_code.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why there are 2 functions here. I could maybe see it if
get_code.tdata
was not exported, but it is. As a user I would be confused as to which one I should use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So (at least when tdata lived in teal) there was a name clash between get_code() in teal.data and get_code in teal.code and this was a way to force the modules to pull the get_code from teal.data -> if there's a nicer way to do this (without making teal.code and teal.data have a dependency) then happy to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about axing
get_code.tdata
and just useget_code_tdata
then? It feels like an unnecessary complexity to have both.If we keep
get_code.tdata
though, the generic documentation should be updated. Right now the generic reads@param x ([
TealDatasetConnector] or [
TealDataset]). If of class
characterwill be treated as file to read.
It should also saytdata
in this case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using S3 here and for metadata feels like overkill.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.