Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output of TealData should be tdata #121

Closed
nikolas-burkoff opened this issue Nov 23, 2022 · 1 comment
Closed

Output of TealData should be tdata #121

nikolas-burkoff opened this issue Nov 23, 2022 · 1 comment
Assignees
Labels

Comments

@nikolas-burkoff
Copy link
Contributor

nikolas-burkoff commented Nov 23, 2022

Should be done with insightsengineering/teal#783

We are aiming to make tdata the universal data object in the teal framework. This issue is to update the teal.data package so that the data coming out of it for teal::init is of type tdata

  1. The class definition of tdata should be moved out of teal and into here
  2. TealData$pull() should output a tdata object
  3. For non DDL data a tdata object should be created from the datasets
  4. tdata should have CodeClass

In the future insightsengineering/teal#937 along with insightsengineering/teal#764 (comment) will simplify the teal.data api and push the use of tdata further into teal.data but that is not this issue

@gogonzo
Copy link
Contributor

gogonzo commented Nov 29, 2022

Probably we need to store CodeClass in tdata as we need a way to subset code for selected datasets. code could be an expression only if we decide to not subset the code or if we figure out this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants