Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datanames in vignettes #239
base: main
Are you sure you want to change the base?
datanames in vignettes #239
Changes from all commits
97b5092
9bb5da1
e90d07b
5dc7720
04cb357
418d248
97f5968
ecb3241
3ec91a1
98021e2
8be3e69
373634e
394edf1
79c100d
2d06288
6cbea73
059165f
b2b428d
12360f7
d60755c
fa139e0
a44e53c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about using
pillar::type_sum
to get the class type?We would use the same naming as
tidyverse
and it would get some extra specificity/weird cases (numeric
->dbl
, rlang::missing_arg/symbol/quote/name and I'm sure some others)The loss here would be shorter names and an extra dependency just for the
show.qenv
method(same to be applied to
hidden
class below)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of changing original class names neither using extra dependency for it
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.