-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic chunks vignette #21
Conversation
Code Coverage Summary
Results for commit: 96a65bb Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put some initial comments in, I'll take another look when you let me know you're happy.
I might have created a small app explicitly creating chunks as well as I think that aids explanation but up to you
To be consistent, change the name of |
gitleak/PII check will pass after this merge insightsengineering/r.pkg.template#79 |
@arkadiuszbeer done. |
Co-authored-by: Nikolas Burkoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there now (the docs are in much much better shape than they were)
- Do we need a PR in agile-R removing the articles and just pointing to these vignettes?
- I think these vignettes along with the basic module example should give people a good basic understanding of chunks
Co-authored-by: Nikolas Burkoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this looks good 👍
closes #2
The Basic chunks is divided into 2 parts:
Get started
vignette: Reproducibility, reproducibility in teal and chunks as a concept.Basic chunks
vignette: Definition of chunks, methods, step-by-step to understand the sequence of using chunks, implicit vs explicit usageThe advanced vignette #1 will host the
chunks in shiny app
,chunks in teal app
andchunks tricks
.