Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshots #92

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Update snapshots #92

merged 3 commits into from
Jan 8, 2024

Conversation

ayogasekaram
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Unit Tests Summary

  1 files  113 suites   3m 41s ⏱️
253 tests 237 ✅  16 💤 0 ❌
505 runs  253 ✅ 252 💤 0 ❌

Results for commit fff27b3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💔 $13.83$ $+1.75$ $0$ $0$ $0$ $0$
table_aet02 💔 $9.09$ $+1.19$ $0$ $0$ $0$ $0$
table_aet04 💔 $13.74$ $+1.75$ $0$ $0$ $0$ $0$
table_aet04_pi 💔 $8.08$ $+1.11$ $0$ $0$ $0$ $0$
table_ent 💔 $16.78$ $+2.06$ $0$ $0$ $0$ $0$
table_lbt13 💔 $12.73$ $+1.55$ $0$ $0$ $0$ $0$
table_lbt14 💔 $9.42$ $+1.22$ $0$ $0$ $0$ $0$
table_vst01 💔 $0.29$ $+1.07$ $+1$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
table_vst01 💔 $0.29$ $+1.07$ VST01_default_variant_is_produced_correctly

Results for commit 4e7effc

♻️ This comment has been updated with latest results.

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@shajoezhu
Copy link
Contributor

I was wondering what is causing the font changing?

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ayogasekaram , can you resolve the conflict please. thanks

@ayogasekaram ayogasekaram requested a review from shajoezhu January 5, 2024 14:41
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @ayogasekaram , happy to move forward, but lets look into why fonts change. Thanks

@shajoezhu shajoezhu merged commit 57488a2 into main Jan 8, 2024
24 checks passed
@shajoezhu shajoezhu deleted the update_snapshots@main branch January 8, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants