Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify count_occurrences indent mods #73

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Simplify count_occurrences indent mods #73

merged 3 commits into from
Oct 31, 2023

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Oct 27, 2023 •
edited
Loading

Closes #72

Corresponds to insightsengineering/tlg-catalog#139

Also reverted snapshot for ratet01 to hopefully fix checks.

@edelarua edelarua added the sme label Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

Unit Tests Summary

    1 files  112 suites   3m 52s ⏱️
249 tests 238 ✔️   11 💤 0 ❌
502 runs  254 ✔️ 248 💤 0 ❌

Results for commit cb143e8.

♻️ This comment has been updated with latest results.

ayogasekaram
ayogasekaram approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks @edelarua

@edelarua edelarua merged commit f030089 into main Oct 31, 2023
24 checks passed
@edelarua edelarua deleted the 72_count_occurrences_indents@main branch October 31, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayogasekaram ayogasekaram ayogasekaram approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify count_occurrences indent mods
2 participants
@edelarua @ayogasekaram