Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options for strict tests; few enhancements #114

Merged
merged 11 commits into from
Mar 1, 2024
Merged

options for strict tests; few enhancements #114

merged 11 commits into from
Mar 1, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jan 24, 2024

Please review the changes carefully and let me know if there is something you don't like.

@pawelru pawelru marked this pull request as ready for review January 29, 2024 08:45
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Unit Tests Summary

  1 files  111 suites   11m 47s ⏱️
245 tests 234 ✅  11 💤 0 ❌
499 runs  256 ✅ 243 💤 0 ❌

Results for commit 6737049.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
table_aet04 💔 $225.62$ $+2.71$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
table_aet04 💔 $25.66$ $+1.20$ AET04_variant_2_is_produced_correctly_Fill_in_of_Treatment_Groups_
table_aet04 💔 $49.29$ $+1.10$ AET04_variant_3_is_produced_correctly_Fill_in_of_Grades_
table_aet04 💔 $41.24$ $+2.35$ AET04_variant_4_is_produced_correctly_Collapsing_of_Grades_grades_1_2_grades_3_4_5_
table_aet04 💚 $8.69$ $-1.94$ AET04_variant_8_is_produced_correctly_with_an_Incidence_Rate_of_at_Least_X_Patients_

Results for commit f829201

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu added the sme label Feb 19, 2024
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please investigate the cause of the snapshot changes, is it just because of data changing?

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! We can unlock this, then in the issue #127 we can take care having fully updated snapshots

@pawelru
Copy link
Contributor Author

pawelru commented Mar 1, 2024

Thank you! Merging this

@pawelru pawelru merged commit 10b6700 into main Mar 1, 2024
25 checks passed
@pawelru pawelru deleted the strict_tests branch March 1, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants