Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and testing extreme templates #968

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Fixes and testing extreme templates #968

merged 8 commits into from
Dec 6, 2024

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades added this to the flattern Rtables milestone Dec 4, 2024
This was linked to issues Dec 4, 2024
ae tables AET04 AET06 #960
Closed
forest plot tables FSTG01 #961
Closed
Stats on the columns (PK tables) PKPT01, PKPT03 #963
Closed
Shift tables (lab, ae) LBT14 #964
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Unit Tests Summary

    1 files     28 suites   1m 35s ⏱️
  218 tests   218 ✅ 0 💤 0 ❌
1 579 runs  1 579 ✅ 0 💤 0 ❌

Results for commit 33bac3e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Result Data Frames 👶 $+0.06$ as_result_df_works_with_analyze_only_tables_odd_num_of_path_elements_

Results for commit 1d5233b

♻️ This comment has been updated with latest results.

edelarua
edelarua approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Davide! A few suggestions but otherwise all great once the failing tests are fixed!! :)

R/tt_as_df.R Outdated Show resolved Hide resolved
tests/testthat/test-result_data_frame.R Outdated Show resolved Hide resolved
Melkiades and others added 2 commits December 5, 2024 09:34
@Melkiades @edelarua
Update R/tt_as_df.R
d1317bf 
Co-authored-by: Emily de la Rua <[email protected]>
Signed-off-by: Davide Garolini <[email protected]>
@Melkiades @edelarua
Update tests/testthat/test-result_data_frame.R
4ce30a9 
Co-authored-by: Emily de la Rua <[email protected]>
Signed-off-by: Davide Garolini <[email protected]>
@Melkiades Melkiades enabled auto-merge (squash) December 5, 2024 08:38
@Melkiades Melkiades merged commit cf8e56a into main Dec 6, 2024
26 checks passed
@Melkiades Melkiades deleted the 959_more_templates@main branch December 6, 2024 08:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edelarua edelarua edelarua approved these changes

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram ayogasekaram is a code owner

Assignees
No one assigned
Labels
ARD sme
Projects
None yet
Milestone
flattern Rtables
3 participants
@Melkiades @edelarua @shajoezhu