Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support display of higher-level ns #876

Merged
merged 47 commits into from
Jun 16, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
c761da9
Support display of higher-level ns
gmbecker Jun 4, 2024
7b738d1
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
dependabot-preview[bot] Jun 4, 2024
4f9a3f8
[skip style] [skip vbump] Restyle files
github-actions[bot] Jun 4, 2024
4c7d5ca
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
dependabot-preview[bot] Jun 4, 2024
1e56f80
add news entries
gmbecker Jun 4, 2024
87ac9e8
Merge branch '135_higher_level_ns' of github.com:insightsengineering/…
gmbecker Jun 4, 2024
819f249
clean up unused code, a few new tests
gmbecker Jun 4, 2024
e96b4f2
[skip style] [skip vbump] Restyle files
github-actions[bot] Jun 4, 2024
7b70e3f
Update .pre-commit-config.yaml
Melkiades Jun 6, 2024
4ac4f18
fixing NEWS
Melkiades Jun 7, 2024
a8dcf58
adding vignette
Melkiades Jun 7, 2024
22b3e8e
update
Melkiades Jun 7, 2024
1f7c316
[skip style] [skip vbump] Restyle files
github-actions[bot] Jun 7, 2024
b6a70ba
fixing docs
Melkiades Jun 7, 2024
1ff6da5
Merge branch '135_higher_level_ns' of github.com:Roche/rtables into 1…
Melkiades Jun 7, 2024
4f4aa19
[skip style] [skip vbump] Restyle files
github-actions[bot] Jun 7, 2024
5823152
fixes
Melkiades Jun 7, 2024
280bd86
[skip style] [skip vbump] Restyle files
github-actions[bot] Jun 7, 2024
4942bd9
rm tab from vignette header
pawelru Jun 10, 2024
013871c
some solving, some issues
Melkiades Jun 10, 2024
4ae186c
fixing links
Melkiades Jun 10, 2024
ea1f450
Respecting format functions too
Melkiades Jun 10, 2024
404a4fe
why?
Melkiades Jun 10, 2024
f7c5b84
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
dependabot-preview[bot] Jun 10, 2024
7ba7f96
[skip style] [skip vbump] Restyle files
github-actions[bot] Jun 10, 2024
516563e
Update R/tree_accessors.R
gmbecker Jun 10, 2024
0585e3e
Apply suggestions from code review
gmbecker Jun 10, 2024
1b89b96
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
dependabot-preview[bot] Jun 10, 2024
6729343
rework col_counts vignette
gmbecker Jun 10, 2024
b49e1ad
update WORDLIST for spellcheck exclusions
pawelru Jun 11, 2024
0329d10
Merge branch 'main' into 135_higher_level_ns
pawelru Jun 11, 2024
65938dc
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
dependabot-preview[bot] Jun 11, 2024
75310ca
update vign
Melkiades Jun 11, 2024
4020067
update wordlist and links to vignette (tmp)
Melkiades Jun 11, 2024
cb84865
some additions to docs
Melkiades Jun 11, 2024
66482c3
fix
Melkiades Jun 11, 2024
98e37f3
[skip style] [skip vbump] Restyle files
github-actions[bot] Jun 11, 2024
b96ec34
empty
Melkiades Jun 11, 2024
0fd1ec5
fix
Melkiades Jun 11, 2024
99dbd7f
fix
Melkiades Jun 12, 2024
ea09b2e
Merge branch 'main' into 135_higher_level_ns
Melkiades Jun 12, 2024
2254a04
fix regression that setting colcounts in build_table didn't turn on d…
gmbecker Jun 12, 2024
aa90185
Merge branch 'main' into 135_higher_level_ns
gmbecker Jun 12, 2024
7080e87
Apply suggestions from code review
shajoezhu Jun 13, 2024
bb853f8
fix regression where overridden in build_table not passed to .N_col a…
gmbecker Jun 14, 2024
c8817d2
[skip style] [skip vbump] Restyle files
github-actions[bot] Jun 14, 2024
8ba5023
Empty-Commit
shajoezhu Jun 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repos:
hooks:
- id: roxygenize
additional_dependencies:
- formatters
- insightsengineering/formatters
Melkiades marked this conversation as resolved.
Show resolved Hide resolved
- magrittr
- methods
- checkmate
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: rtables
Title: Reporting Tables
Version: 0.6.7.9003
Version: 0.6.7.9004
Date: 2024-06-04
Authors@R: c(
person("Gabriel", "Becker", , "[email protected]", role = "aut",
Expand Down
16 changes: 16 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ export("col_footnotes<-")
export("col_info<-")
export("col_total<-")
export("colcount_format<-")
export("colcount_na_str<-")
export("colcount_visible<-")
export("content_table<-")
export("facet_colcount<-")
export("facet_colcounts_visible<-")
Melkiades marked this conversation as resolved.
Show resolved Hide resolved
export("fnotes_at_path<-")
export("header_section_div<-")
export("horizontal_sep<-")
Expand Down Expand Up @@ -74,8 +78,11 @@ export(col_paths)
export(col_paths_summary)
export(col_total)
export(colcount_format)
export(colcount_na_str)
export(colcount_visible)
export(collect_leaves)
export(coltree)
export(coltree_structure)
export(compare_rtables)
export(cont_n_allcols)
export(cont_n_onecol)
Expand All @@ -91,6 +98,7 @@ export(export_as_docx)
export(export_as_pdf)
export(export_as_tsv)
export(export_as_txt)
export(facet_colcount)
export(find_degen_struct)
export(format_rcell)
export(get_formatted_cells)
Expand Down Expand Up @@ -138,6 +146,7 @@ export(remove_split_levels)
export(reorder_split_levels)
export(result_df_specs)
export(rheader)
export(rm_all_colcounts)
export(row_cells)
export(row_footnotes)
export(row_paths)
Expand Down Expand Up @@ -208,7 +217,10 @@ exportMethods("col_footnotes<-")
exportMethods("col_info<-")
exportMethods("col_total<-")
exportMethods("colcount_format<-")
exportMethods("colcount_na_str<-")
exportMethods("colcount_visible<-")
exportMethods("content_table<-")
exportMethods("facet_colcount<-")
exportMethods("fnotes_at_path<-")
exportMethods("horizontal_sep<-")
exportMethods("main_footer<-")
Expand Down Expand Up @@ -239,10 +251,13 @@ exportMethods(col_footnotes)
exportMethods(col_info)
exportMethods(col_total)
exportMethods(colcount_format)
exportMethods(colcount_na_str)
exportMethods(colcount_visible)
exportMethods(collect_leaves)
exportMethods(coltree)
exportMethods(content_table)
exportMethods(dim)
exportMethods(facet_colcount)
exportMethods(head)
exportMethods(horizontal_sep)
exportMethods(length)
Expand All @@ -266,6 +281,7 @@ exportMethods(rbind2)
exportMethods(ref_index)
exportMethods(ref_msg)
exportMethods(ref_symbol)
exportMethods(rm_all_colcounts)
exportMethods(row.names)
exportMethods(row_cells)
exportMethods(row_footnotes)
Expand Down
11 changes: 11 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
## rtables 0.6.7.9004
Melkiades marked this conversation as resolved.
Show resolved Hide resolved
### New Features
* all tables are now guaranteed to have fully path-traversable column structures (all facets in column space uniquely reachable via pathing) @gmbecker
* display of higher order (non-leaf) column counts is now supported (#135) @gmbecker
* column count visibility can be set independently for each block of sibling facets (#752) @gmbecker
* `split_cols_by*` functions now accept `show_colcounts` and `colcount_format` arguments
* new (column-) path based `colcount_visible` getter and setter for changing column count visibility in an already built table @gmbecker
* new (column-) path based `facet_colcount` getter and setter column count value at arbitrary point in column structure of built table @gmbecker
* new `facet_colcounts_visible` setter to conveniently set the column count visibility of a set of sibling facets in column space
* new `rm_all_colcounts` convenience function for turning off visibility all column counts throughout the column structure @gmbecker

## rtables 0.6.7.9003
### New Features
* Added `top_level_section_div` for `basic_table` to set section dividers for top level rows.
Expand Down
Loading
Loading