-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate export_as_pdf #798
Conversation
Merge branch 'main' into 758_migrate_pdf_export@main # Conflicts: # R/tt_export.R # man/export_as_pdf.Rd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Don't forget to also update NEWS!!
For future reference to manage dependent PRs, since we use staged dependencies, you should either name your branch the same thing as the branch with required upstream changes (in this case the formatters
branch 94_internalize_function@main
), or with that branch as a suffix - i.e. this_branch_name@94_internalize_function@main
. If you don't do that you will need to merge in the upstream PR first, then rerun the checks so that they pass.
perhaps, should have used "758_migrate_pdf_export@94_internalize_function@main" as the branch name? but thats ok, we can merge the formatter one in first |
Code Coverage Summary
Diff against main
Results for commit: 645dd35 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance Difference
Results for commit eeffe77 ♻️ This comment has been updated with latest results. |
closes #758