Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer guide to pkgdown site #744

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Add developer guide to pkgdown site #744

merged 8 commits into from
Nov 1, 2023

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Oct 12, 2023

Closes #735

Individual .Rmd files can be merged in first from their branches.

.html files need to be manually formatted & generated formatted via the "Knit" button since they are not stored in the Articles section.

To merge:

@edelarua edelarua added the sme label Oct 12, 2023
@Melkiades
Copy link
Contributor

@edelarua I am wondering if you want to merge our branches here or first main and then this

@edelarua
Copy link
Contributor Author

@edelarua I am wondering if you want to merge our branches here or first main and then this

Either one works - I was just working on getting the output in the site how we will want it.

@edelarua edelarua marked this pull request as ready for review October 14, 2023 00:41
@shajoezhu
Copy link
Collaborator

hey guys, thanks for the changes here. Let's unblock this after the current release

@shajoezhu shajoezhu marked this pull request as draft October 16, 2023 04:34
@edelarua edelarua marked this pull request as ready for review November 1, 2023 14:49
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me! Lets see what is the output for navbar... no icon? :D Thanks Emily for working this out

@edelarua edelarua merged commit b93136f into main Nov 1, 2023
19 checks passed
@edelarua edelarua deleted the 735_dev_guide@main branch November 1, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev guide
3 participants