Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow suppression of column counts in select columns #752

Closed
edelarua opened this issue Oct 17, 2023 · 1 comment · Fixed by #876
Closed

Allow suppression of column counts in select columns #752

edelarua opened this issue Oct 17, 2023 · 1 comment · Fixed by #876
Labels
discussion enhancement sme

Comments

@edelarua
Copy link
Contributor

In some tables it would be helpful to hide/not to print column counts for specific columns, such as columns that perform operations on data from other columns where counts don't make sense (e.g. risk difference). Currently column count display is all or nothing and I'm not sure how difficult this would be to change.

See pharmaverse/cardinal#149 for an example of where this feature would be used.
@edelarua edelarua mentioned this issue Oct 17, 2023
Open
@Melkiades
Copy link
Contributor

This is quite complicated. For me, the API design is not obvious. Anyway, connected with #135

@gmbecker gmbecker mentioned this issue Jun 4, 2024
Merged
@Melkiades Melkiades linked a pull request Jun 5, 2024 that will close this issue
Support display of higher-level ns #876
Merged
shajoezhu added a commit that referenced this issue Jun 16, 2024
@gmbecker @dependabot-preview
@github-actions @Melkiades @pawelru @shajoezhu
Support display of higher-level ns (#876)
8e63fb9 
closes #135 and #752

---------

Signed-off-by: Davide Garolini <[email protected]>
Signed-off-by: Gabe Becker <[email protected]>
Signed-off-by: Pawel Rucki <[email protected]>
Signed-off-by: Joe Zhu <[email protected]>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Davide Garolini <[email protected]>
Co-authored-by: Pawel Rucki <[email protected]>
Co-authored-by: Joe Zhu <[email protected]>
Co-authored-by: shajoezhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support display of higher-level ns insightsengineering/rtables
2 participants
@Melkiades @edelarua