Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the package before testing it #21

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Load the package before testing it #21

merged 2 commits into from
Nov 26, 2024

Conversation

llrs-roche
Copy link
Contributor

The dependency checks on r-universe fail because they run R CMD check, which fails the tests.
The problem seems to come from not loading rtables.officer and using rtables instead of rtables.officer on testthat machinery (not sure of how this affects the results).

I also added the Config/testthat/edition: 3 because it is currently standard and used in other packages and used on rtables.

Note: This code pass checks but doesn't use testthat conditionally even though it is a suggested package.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@llrs-roche
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  ---------------------------------------------------------------------
R/as_flextable.R        453      24  94.70%   117, 160, 178, 201-205, 323, 569-572, 581, 635, 641, 669-672, 865-869
R/export_as_docx.R      107      28  73.83%   61, 73-100, 222
TOTAL                   560      52  90.71%

Results for commit: 8927874

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Unit Tests Summary

 1 files   2 suites   9s ⏱️
 7 tests  7 ✅ 0 💤 0 ❌
19 runs  19 ✅ 0 💤 0 ❌

Results for commit 8927874.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
as_flextable 💚 $9.29$ $-2.21$ $0$ $0$ $0$ $0$

Results for commit f8d2411

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! looks great! thanks @llrs-roche

@llrs-roche llrs-roche merged commit 42ad99e into main Nov 26, 2024
28 of 29 checks passed
@llrs-roche llrs-roche deleted the fix_tests@main branch November 26, 2024 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants