-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load the package before testing it #21
Conversation
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
Code Coverage Summary
Results for commit: 8927874 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 2 suites 9s ⏱️ Results for commit 8927874. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit f8d2411 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! looks great! thanks @llrs-roche
The dependency checks on r-universe fail because they run R CMD check, which fails the tests.
The problem seems to come from not loading rtables.officer and using rtables instead of rtables.officer on testthat machinery (not sure of how this affects the results).
I also added the Config/testthat/edition: 3 because it is currently standard and used in other packages and used on rtables.
Note: This code pass checks but doesn't use testthat conditionally even though it is a suggested package.