Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refining split #19

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Refining split #19

merged 7 commits into from
Nov 22, 2024

Conversation

Melkiades
Copy link
Contributor

Fixes #18

Copy link
Contributor

github-actions bot commented Nov 20, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@Melkiades
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Unit Tests Summary

 1 files   2 suites   10s ⏱️
 7 tests  7 ✅ 0 💤 0 ❌
19 runs  19 ✅ 0 💤 0 ❌

Results for commit 26ed0c1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Exporting to txt, pdf, rtf, and docx 💀 $3.83$ $-3.83$ $-8$ $0$ $0$ $0$
as_flextable 👶 $+7.22$ $+14$ $0$ $0$ $0$
export_as_docx 👶 $+3.00$ $+5$ $0$ $0$ $0$
tt_as_flextable 💀 $5.03$ $-5.03$ $-12$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Exporting to txt, pdf, rtf, and docx 💀 $0.28$ $-0.28$ export_as_doc_produces_a_warning_if_manual_column_widths_are_used
Exporting to txt, pdf, rtf, and docx 💀 $2.65$ $-2.65$ export_as_doc_works_thanks_to_tt_to_flextable
Exporting to txt, pdf, rtf, and docx 💀 $0.81$ $-0.81$ export_as_txt_works_with_and_without_pagination
Exporting to txt, pdf, rtf, and docx 💀 $0.08$ $-0.08$ path_enriched_df_works_for_tables_with_a_column_that_has_all_length_1_elements
as_flextable 👶 $+3.29$ Can_create_flextable_object_that_works_with_different_styles
as_flextable 👶 $+0.55$ check_colwidths_in_flextable_object
as_flextable 👶 $+1.52$ check_pagination
as_flextable 👶 $+1.13$ check_titles_bold_and_html_theme
as_flextable 👶 $+0.73$ tt_to_flextable_does_not_create_different_cells_when_colcounts_or_multiple_on_different_lines
export_as_docx 👶 $+0.29$ export_as_docx_produces_a_warning_if_manual_column_widths_are_used
export_as_docx 👶 $+2.71$ export_as_docx_works_thanks_to_tt_to_flextable
tt_as_flextable 💀 $2.94$ $-2.94$ Can_create_flextable_object_that_works_with_different_styles
tt_as_flextable 💀 $0.21$ $-0.21$ check_pagination
tt_as_flextable 💀 $1.06$ $-1.06$ check_titles_bold_and_html_theme
tt_as_flextable 💀 $0.82$ $-0.82$ tt_to_flextable_does_not_create_different_cells_when_colcounts_or_multiple_on_different_lines

Results for commit 1d078e8

♻️ This comment has been updated with latest results.

R/package.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Melkiades , can you add formatters for rtables :: to

all_footers all_titles collect_leaves coltree decimal_align font_spec
make_row_df matrix_form mf_aligns mf_nlheader mf_spans mf_strings
obj_name paginate_table propose_column_widths spans_to_viscell
value_names

thanks!

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @Melkiades

@Melkiades Melkiades merged commit 441c885 into main Nov 22, 2024
28 of 29 checks passed
@Melkiades Melkiades deleted the 18_Correct_Split@main branch November 22, 2024 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some original code was NOT exported here - to revert to original code from split
2 participants