Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds min package version #139

Merged
merged 9 commits into from
Sep 15, 2023
Merged

Adds min package version #139

merged 9 commits into from
Sep 15, 2023

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Jul 19, 2023

WIP :: parent issue: insightsengineering/nestdevs-tasks#7

Supersede:

🔴 Checklist for PR Reviewer

  • Tag yourself next to this repo on Specify minimal version dependencies + add action nestdevs-tasks#7
  • Package versions are the same or higher than main
  • Package list is the same
    • Only exception is rmarkdown (may have been removed on Suggests)
  • All packages in Imports, Depends & Suggests are in new section Config/Needs/verdepcheck
  • Added entry to NEWS.md
  • Last scheduled.yaml action was run succesfully (all 4 strategies)
    • important: it's not the last commit, it's the one that runs 4 Scheduled 🕰️ / Dependency actions
  • scheduled.yaml SHOULD NOT have any push on any branches

🔴 What's needed before merging?

This PR depends on some upstream changes that need to be finalized/merged before being ready to review.

Change in code

  • formatters release of the next version and update DESCRIPTION accordingly
    • fmt_config is required and only available at formatters@main atm
  • verdepcheck.yml action (see comments)
    • Remove on: push section
    • Change branch to main

PRS

Changes description

  • Adds minimum version for packages DESCRIPTION
  • Adds Config/Need/verdepcheck section in DESCRIPTION
  • Updates verdepcheck action

@averissimo averissimo marked this pull request as ready for review September 4, 2023 15:20
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        40       1  97.50%   99
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 137-140, 143, 227-233
R/rlistings.R              156      20  87.18%   156-157, 161-162, 196-198, 361-364, 368-371, 400, 404-407
TOTAL                      297      35  88.22%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 36536b1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Unit Tests Summary

  1 files    4 suites   4s ⏱️
25 tests 19 ✔️ 6 💤 0
65 runs  58 ✔️ 7 💤 0

Results for commit 91138db.

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor

m7pr commented Sep 14, 2023

I see @kartikeyakirar manually run Scheduled workflow a minute ago, once it passes I think we can merge

Copy link

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge back from main. before merging .
LGTM!

@averissimo averissimo merged commit 8d2560f into main Sep 15, 2023
@averissimo averissimo deleted the verdepcheck_action branch September 15, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants