Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue306 fix radqlqc #307

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Issue306 fix radqlqc #307

wants to merge 18 commits into from

Conversation

sob2021
Copy link
Contributor

@sob2021 sob2021 commented May 13, 2024

Pull Request

Fixes #306

Copy link
Contributor

github-actions bot commented May 13, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@sob2021
Copy link
Contributor Author

sob2021 commented May 13, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented May 13, 2024

Unit Tests Summary

 1 files   4 suites   23s ⏱️
61 tests 38 ✅ 20 💤 0 ❌ 3 🔥
99 runs  76 ✅ 20 💤 0 ❌ 3 🔥

For more details on these errors, see this check.

Results for commit 673dc21.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 13, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
metadata 💚 $9.14$ $-1.40$ $0$ $0$ $0$ $+1$
rdata 💚 $11.41$ $-3.42$ $-7$ $0$ $0$ $+1$
row_values 💚 $9.01$ $-1.79$ $0$ $-1$ $0$ $+1$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
metadata 💚 $1.78$ $-1.32$ metadata_matches_radqlqc
rdata 💚 $6.17$ $-3.15$ r_data_functions_work
row_values 💚 $1.98$ $-1.65$ radqlqc_produces_expected_values

Results for commit ca21166

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu marked this pull request as draft May 14, 2024 15:43
@Melkiades
Copy link
Contributor

@shajoezhu Stella left; how should we proceed with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ADQLQC: Correct bug in EX028 derivation
3 participants