Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options for strict tests; few enhancements #295

Merged
merged 7 commits into from
Mar 4, 2024
Merged

options for strict tests; few enhancements #295

merged 7 commits into from
Mar 4, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jan 24, 2024

Please review the changes carefully and let me know if there is something you don't like.

@pawelru pawelru marked this pull request as ready for review January 29, 2024 08:44
Copy link
Contributor

github-actions bot commented Jan 29, 2024

badge

Code Coverage Summary

Filename         Stmts    Miss  Cover    Missing
-------------  -------  ------  -------  --------------------------
R/radab.R          284       1  99.65%   390
R/radae.R          198       3  98.48%   76, 95, 284
R/radaette.R       203       4  98.03%   50, 72, 78, 260
R/radcm.R          150       2  98.67%   51, 204
R/raddv.R           91       2  97.80%   54, 137
R/radeg.R          270       1  99.63%   370
R/radex.R          229       1  99.56%   320
R/radhy.R          136       1  99.26%   198
R/radlb.R          334       1  99.70%   426
R/radmh.R           93       2  97.85%   45, 134
R/radpc.R           85       1  98.82%   125
R/radpp.R           83       1  98.80%   153
R/radqlqc.R       1024       7  99.32%   337, 855, 1153-1157
R/radqs.R          118       1  99.15%   185
R/radrs.R          122       3  97.54%   47, 54, 183
R/radsaftte.R        1       0  100.00%
R/radsl.R          180       1  99.44%   260
R/radsub.R         140       2  98.57%   177, 241
R/radtr.R          124       0  100.00%
R/radtte.R         208       4  98.08%   52, 72, 84, 279
R/radvs.R          178       1  99.44%   251
R/utils.R          148      11  92.57%   62, 249, 261, 265, 294-300
TOTAL             4399      50  98.86%

Diff against main

Filename       Stmts    Miss  Cover
-----------  -------  ------  -------
R/radab.R         -9       0  -0.01%
R/radpc.R         +2       0  +0.03%
R/radpp.R         +2       0  +0.03%
R/radqlqc.R      +39       0  +0.03%
TOTAL            +34       0  +0.01%

Results for commit: 39eaaba

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Unit Tests Summary

  1 files   4 suites   28s ⏱️
 61 tests 40 ✅ 21 💤 0 ❌
106 runs  85 ✅ 21 💤 0 ❌

Results for commit 39eaaba.

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu added the sme label Feb 19, 2024
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @pawelru

@shajoezhu shajoezhu self-assigned this Mar 4, 2024
@shajoezhu shajoezhu merged commit fad0aae into main Mar 4, 2024
24 checks passed
@shajoezhu shajoezhu deleted the strict_tests branch March 4, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants