Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test branch #269

Closed
wants to merge 6 commits into from
Closed

Test branch #269

wants to merge 6 commits into from

Conversation

llrs-roche
Copy link

Dummy pull request to test new actions on insightsengineering/setup-r-dependencies#19 and on insightsengineering/teal#1411

@llrs-roche llrs-roche requested a review from a team as a code owner November 13, 2024 13:43
@llrs-roche llrs-roche marked this pull request as draft November 13, 2024 13:43
@cicdguy
Copy link
Contributor

cicdguy commented Nov 13, 2024

Looks identical to @pawelru's PR: #268

@llrs-roche
Copy link
Author

llrs-roche commented Nov 13, 2024

Yes @cicdguy, apologies for the notification. I realized too late I didn't use the draft PR.

I am having trouble testing changes on teal insightsengineering/setup-r-dependencies#19 with the ones I made on setup-r-dependencies. One of the hypothesis is that having a branch with an @ messed with the github action system, so I created this branch and PR to test if without it the checks on teal work.

@cicdguy
Copy link
Contributor

cicdguy commented Nov 13, 2024

Yeah no problem. Feel free to test as you desire. Just wanted to let you know that the duplicity exists. Cheers

@llrs-roche
Copy link
Author

Apologies for the noise. At the end using a branch without @ and changing the testing PR from draft to ready for review worked well to test changes on the CI setup.

As this has been merged and released on a rolling version it will be picked up and this PR doesn't need to be merged.

@llrs-roche llrs-roche closed this Nov 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@pawelru pawelru deleted the test_branch branch November 14, 2024 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants