Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use setup-r-deps in revdepcheck #255

Merged
merged 4 commits into from
Oct 2, 2024
Merged

use setup-r-deps in revdepcheck #255

merged 4 commits into from
Oct 2, 2024

Conversation

@pawelru pawelru marked this pull request as ready for review September 25, 2024 16:43
@pawelru pawelru requested a review from a team as a code owner September 25, 2024 16:43
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit d166a2a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

badge

Code Coverage Summary

Filename      Stmts    Miss  Cover    Missing
----------  -------  ------  -------  ---------
R/hello.R        20       6  70.00%   55-60
TOTAL            20       6  70.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 3ce2b07

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

pawelru added a commit to insightsengineering/r-revdepcheck-action that referenced this pull request Oct 2, 2024
alternative to:
#3

test those two together:
- insightsengineering/r.pkg.template#255
- #4

This would require additional inputs: `lookup-refs` action parameter. I
think that this is ok since we have to have an information where to find
non-cran dependencies. The Remotes field (if provided) will be used
instead of this.
See:
insightsengineering/teal.goshawk@main...refs/heads/fix_non_cran2
as an example

Tests:
-
https://github.com/insightsengineering/teal.goshawk/actions/workflows/scheduled.yaml?query=branch%3Afix_non_cran2
-
https://github.com/insightsengineering/teal.osprey/actions/workflows/scheduled.yaml?query=branch%3Afix_non_cran2

---------

Signed-off-by: Pawel Rucki <[email protected]>
Co-authored-by: Marcin <[email protected]>
@pawelru pawelru merged commit 1c58002 into main Oct 2, 2024
23 checks passed
@pawelru pawelru deleted the fix_non_cran2 branch October 2, 2024 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants