Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show expandable R CMD check logs + upload them as artifact #241

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Show expandable R CMD check logs + upload them as artifact #241

merged 2 commits into from
Jun 17, 2024

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif requested a review from pawelru June 17, 2024 13:06
@walkowif walkowif requested a review from a team as a code owner June 17, 2024 13:06
@github-actions GitHub Actions
Copy link
Contributor

badge

Code Coverage Summary

Filename      Stmts    Miss  Cover    Missing
----------  -------  ------  -------  ---------
R/hello.R        20       6  70.00%   55-60
TOTAL            20       6  70.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2934387

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit 2934387.

cicdguy
cicdguy reviewed Jun 17, 2024
View reviewed changes
.github/workflows/build-check-install.yaml
${{ env.PKGNAME }}.Rcheck/*00build.out
${{ env.PKGNAME }}.Rcheck/*-Ex.Rout
${{ env.PKGNAME }}.Rcheck/tests/testthat.Rout
${{ env.PKGNAME }}.Rcheck/tests/testthat.Rout.fail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't error out if one or more files are missing, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, missing files are simply skipped.

pawelru
pawelru approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@walkowif walkowif merged commit 278d595 into main Jun 17, 2024
26 checks passed
@walkowif walkowif deleted the expandable-r-cmd-check-logs branch June 17, 2024 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cicdguy cicdguy cicdguy approved these changes

@pawelru pawelru pawelru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walkowif @pawelru @cicdguy