Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add r-hub workflow #232

Merged
merged 43 commits into from
Jul 5, 2024
Merged

feat: add r-hub workflow #232

merged 43 commits into from
Jul 5, 2024

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif requested a review from a team as a code owner May 15, 2024 14:53
Copy link
Contributor

github-actions bot commented May 15, 2024

badge

Code Coverage Summary

Filename      Stmts    Miss  Cover    Missing
----------  -------  ------  -------  ---------
R/hello.R        20       6  70.00%   55-60
TOTAL            20       6  70.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: cc4fc0f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 15, 2024

Unit Tests Summary

3 tests   3 ✅  6s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit cc4fc0f.

♻️ This comment has been updated with latest results.

@walkowif walkowif marked this pull request as draft June 26, 2024 15:18
.github/workflows/rhub.yaml Outdated Show resolved Hide resolved
.github/workflows/rhub.yaml Outdated Show resolved Hide resolved
@walkowif
Copy link
Contributor Author

walkowif commented Jul 3, 2024

This is pending on insightsengineering/setup-r-dependencies#1.

.github/workflows/rhub.yaml Outdated Show resolved Hide resolved
.github/workflows/rhub.yaml Outdated Show resolved Hide resolved
# All supported R-hub platforms can be viewed by running: rhub::rhub_platforms()
# Container-based platforms (as opposed to VM-based Windows and macOS platforms)
# can be also viewed here: https://r-hub.github.io/containers/containers.html
default: 'ubuntu-clang,ubuntu-gcc12,gcc13,ubuntu-next,ubuntu-release,macos-arm64,macos,windows,gcc14,atlas,valgrind,intel,nosuggests,mkl'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening a separate thread to keep the discussion well organised.
This is the results for teal:
image

Take a look at the timings for valgrind. It took 4 times longer than the median timing of all the platforms. If the minutes consumption are in concern - maybe we can remove it? WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, GitHub minutes consumption is not a problem for public repositories (they are free) but we can remove any irrelevant checks, especially if they take a long time.

Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome thanks! Looking forward for propagation into the R pkg repos

@walkowif walkowif changed the title Add R-hub workflow feat: add r-hub workflow Jul 5, 2024
@walkowif walkowif merged commit 3d8f753 into main Jul 5, 2024
30 checks passed
@walkowif walkowif deleted the test-rhub-workflows branch July 5, 2024 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants