Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves problem with second-level dependencies #22

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Dec 20, 2024

Related to insightsengineering/verdepcheck#38

In scenarios where the DESCRIPTION file has top-level dependencies (Depends, Imports, Suggests, Extends) that depend on packages not yet released on CRAN, this new option allows to define repositories that may fill the gap.

In particular, this is important on max strategy, as they might depend on secondary packages that have changes that only exist on the repository.

Changes description

  • Adds new option to add extra repositories
    • If user wants to fully override default repository, they can replace environmental variables
  • Adds styling to first (manual) header
  • Better organizes readme

TODO:

  • Understand how to use this new option in github action matrix

Use case examples

This will be especially helpful with max strategy to allow more packages to be compiled with latest development versions

  • insightsengineering packages can use r-universe.dev to pull secondary dependencies such as formatters
  • Pull all latest development from tidyverse packages by using https://tidyverse.r-universe.dev/builds

release strategy can also use this if downstream packages are not being release on CRAN

min_*** strategy shouldn't use this option

@averissimo averissimo closed this Dec 20, 2024
@averissimo averissimo deleted the allow_custom_repos@main branch December 20, 2024 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@averissimo averissimo restored the allow_custom_repos@main branch December 20, 2024 19:27
@averissimo averissimo reopened this Dec 20, 2024
@insightsengineering insightsengineering unlocked this conversation Dec 20, 2024
@averissimo
Copy link
Contributor Author

See here a workflow run with this PR in tmg's max strategy.

We might be able to do the same using environment variables.

@m7pr m7pr added the core label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants