Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects a typo on checkmate dependency #63

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Corrects a typo on checkmate dependency #63

merged 1 commit into from
Sep 18, 2023

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Sep 15, 2023 •
edited
Loading

Pull Request

Related to insightsengineering/nestdevs-tasks#7

Triggered a manual workflow, see here for status: https://github.com/insightsengineering/nestcolor/actions/runs/6200383565

@averissimo averissimo requested a review from a team September 15, 2023 16:15
@averissimo averissimo marked this pull request as ready for review September 15, 2023 16:15
@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ---------
R/color_palette.R       52       0  100.00%
R/theme_nest.R          15       0  100.00%
R/zzz.R                  6       6  0.00%    2-7
TOTAL                   73       6  91.78%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ddd5154

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

1 files  2 suites   0s ⏱️
5 tests 5 ✔️ 0 💤 0 ❌
6 runs  6 ✔️ 0 💤 0 ❌

Results for commit 07e8ee3.

@averissimo averissimo changed the title fix: correct a typo on version operator Corrects a typo on checkmate dependency Sep 15, 2023
Melkiades
Melkiades approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@Melkiades Melkiades merged commit 5a0c42e into main Sep 18, 2023
@Melkiades Melkiades deleted the checkmate_version@main branch September 18, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m7pr m7pr m7pr approved these changes

@Melkiades Melkiades Melkiades approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averissimo @Melkiades @m7pr