Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verdepcheck fixes #267

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Verdepcheck fixes #267

merged 3 commits into from
Mar 14, 2024

Conversation

pawelru
Copy link
Collaborator

@pawelru pawelru commented Mar 14, 2024

This aims to fix scheduled tests that are currently failing: https://github.com/insightsengineering/formatters/actions/workflows/scheduled.yaml
The rationale outlined here: insightsengineering/teal.logger#49 (comment)

I run te tests and it is passing on all variants. Ready to be reviewed and merged.

Copy link
Contributor

github-actions bot commented Mar 14, 2024

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       194      12  93.81%   88, 104-111, 189, 301, 401, 412, 420
R/generics.R           105       7  93.33%   454, 466, 499, 528, 652-658
R/labels.R              55       7  87.27%   49, 55, 64, 105, 133, 142, 146
R/matrix_form.R        552      50  90.94%   103, 455-456, 544, 557-560, 579, 611, 705-706, 721-726, 756-759, 792-793, 825-826, 870, 1033, 1057-1079, 1121, 1172, 1175, 1179
R/mpf_exporters.R      238      19  92.02%   2, 90-92, 201, 241, 246, 429, 432, 438-441, 479, 551-554, 567
R/page_size.R           45       1  97.78%   172
R/pagination.R         634      49  92.27%   250, 302-305, 407-420, 582, 765-766, 787-797, 1000-1016, 1148, 1155, 1362-1363, 1375-1376, 1390-1391
R/tostring.R           586      49  91.64%   41, 93, 162, 196, 204, 240, 297-300, 393-397, 400-403, 410-415, 492, 631-632, 697-704, 761-765, 849, 864, 958, 1010, 1051, 1096, 1151, 1158
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   29-34
TOTAL                 2429     200  91.77%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 9713c82

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Unit Tests Summary

  1 files    5 suites   9s ⏱️
 43 tests  43 ✅ 0 💤 0 ❌
295 runs  295 ✅ 0 💤 0 ❌

Results for commit 9713c82.

♻️ This comment has been updated with latest results.

Signed-off-by: Pawel Rucki <[email protected]>
@pawelru pawelru enabled auto-merge (squash) March 14, 2024 10:36
@pawelru pawelru added the sme Tracks changes for the sme board label Mar 14, 2024
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Pawel

@pawelru pawelru merged commit 9a2de8f into main Mar 14, 2024
23 checks passed
@pawelru pawelru deleted the verdepcheck_fixes branch March 14, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sme Tracks changes for the sme board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants