Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of newlines in footers; towards fixing pagination for rlistings #246

Merged
merged 31 commits into from
Jan 19, 2024

Conversation

@Melkiades Melkiades added bug Something isn't working enhancement New feature or request sme Tracks changes for the sme board labels Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Unit Tests Summary

  1 files    4 suites   7s ⏱️
 37 tests  37 ✅ 0 💤 0 ❌
250 runs  250 ✅ 0 💤 0 ❌

Results for commit 86414e8.

♻️ This comment has been updated with latest results.

@Melkiades
Copy link
Contributor Author

This PR fixes also insightsengineering/rlistings#183

Copy link
Contributor

github-actions bot commented Jan 9, 2024

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       194      13  93.30%   88, 104-111, 191, 210, 281, 404, 415, 423
R/generics.R           105       7  93.33%   454, 466, 499, 528, 652-658
R/labels.R              55       7  87.27%   49, 55, 64, 105, 133, 142, 146
R/matrix_form.R        502      52  89.64%   103, 455-456, 544, 557-560, 579, 611, 705-706, 721-726, 756-759, 792-793, 825-826, 858, 930, 950-976, 1018, 1069, 1072, 1076
R/mpf_exporters.R      236     102  56.78%   2, 83-85, 193, 233, 238, 421, 424, 430-433, 471-654
R/page_size.R           45       1  97.78%   174
R/pagination.R         610      53  91.31%   250, 302-305, 407-420, 506, 582, 766-767, 788-798, 996-1012, 1078, 1132, 1139, 1166, 1191, 1323-1324, 1336-1337, 1351-1352
R/tostring.R           600      55  90.83%   29-34, 91, 143, 212, 246, 254, 290, 347-350, 443-447, 450-453, 460-465, 542, 681-682, 747-754, 811-815, 899, 914, 1009, 1061, 1102, 1147, 1202, 1209
R/utils.R                3       0  100.00%
TOTAL                 2350     290  87.66%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/matrix_form.R        +33     +21  -3.75%
R/mpf_exporters.R      +12      +6  -0.36%
R/pagination.R         +40      +8  -0.79%
R/tostring.R           +29     +17  -2.51%
TOTAL                 +114     +52  -1.70%

Results for commit: 86414e8

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
table_inset and titles and footers word wrapping 👶 $+0.03$ max_width_is_handled_correctly_as_expected
table_inset and titles and footers word wrapping 👶 $+0.59$ toString_is_silent_when_newline_is_in_decorations_footnotes_titles_as_matrix_form_constructor_expands_all_newlines
table_inset and titles and footers word wrapping 💀 $0.55$ $-0.55$ toString_throws_a_warning_when_newline_is_in_string

Results for commit aede30a

♻️ This comment has been updated with latest results.

@Melkiades Melkiades requested review from shajoezhu, edelarua and ayogasekaram and removed request for edelarua and ayogasekaram January 18, 2024 08:38
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant! Thanks a lot! @Melkiades
this works very well

@Melkiades Melkiades merged commit b7e455b into main Jan 19, 2024
25 checks passed
@Melkiades Melkiades deleted the 243_fix_nl_expansion@main branch January 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request sme Tracks changes for the sme board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants