-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of newlines in footers; towards fixing pagination for rlistings #246
Conversation
…ering/formatters into 243_fix_nl_expansion@main
Unit Tests Summary 1 files 4 suites 7s ⏱️ Results for commit 86414e8. ♻️ This comment has been updated with latest results. |
This PR fixes also insightsengineering/rlistings#183 |
Code Coverage Summary
Diff against main
Results for commit: 86414e8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance DifferenceAdditional test case details
Results for commit aede30a ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brilliant! Thanks a lot! @Melkiades
this works very well
Signed-off-by: Davide Garolini <[email protected]>
Fixes the following issues
To merge with insightsengineering/rlistings#192 (tests and misc) and insightsengineering/rtables#813 (tests and removed titles/footers newline handling)