Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds min package version #182

Merged
merged 10 commits into from
Sep 13, 2023
Merged

Adds min package version #182

merged 10 commits into from
Sep 13, 2023

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Jul 18, 2023

WIP :: parent issue: insightsengineering/nestdevs-tasks#7

Supersede:

🔴 Checklist for PR Reviewer

  • Tag yourself next to this repo on Specify minimal version dependencies + add action nestdevs-tasks#7
  • Package versions are the same or higher than main
  • Package list is the same
    • Only exception is rmarkdown (may have been removed on Suggests)
  • All packages in Imports, Depends & Suggests are in new section Config/Needs/verdepcheck
  • Added entry to NEWS.md
  • Last scheduled.yaml action was run succesfully (all 4 strategies)
    • important: it's not the last commit, it's the one that runs 4 Scheduled 🕰️ / Dependency actions
  • scheduled.yaml SHOULD NOT have any push on any branches

🔴 What's needed before merging?

This PR depends on some upstream changes that need to be finalized/merged before being ready to review.

Change in code

  • verdepcheck.yml action (see comments)
    • Remove on: push section
    • Change branch to main

PRS

Changes description

  • Adds minimum version for packages DESCRIPTION
  • Adds Config/Need/verdepcheck section in DESCRIPTION
  • Updates verdepcheck action

@averissimo averissimo marked this pull request as ready for review September 4, 2023 15:16
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------
R/format_value.R       197      14  92.89%   94, 110-117, 197, 216, 287, 409, 420, 428
R/generics.R            98       4  95.92%   434, 446, 479, 508
R/labels.R              55       7  87.27%   53, 59, 68, 109, 137, 146, 150
R/matrix_form.R        416      27  93.51%   355-356, 451, 463-464, 483, 514, 603-604, 619-624, 651-652, 684-685, 717-718, 750, 836, 884, 936, 938, 941
R/mpf_exporters.R      123      12  90.24%   2, 84-86, 179, 219, 224, 407, 409, 414-415, 441
R/page_size.R           45       1  97.78%   169
R/pagination.R         475      19  96.00%   400, 472, 592-593, 598, 652-653, 671-679, 966, 973, 1127-1128, 1140-1141, 1153-1154
R/tostring.R           426      17  96.01%   85, 186, 194-195, 230, 283-284, 514-515, 599, 614, 722, 775, 816, 861, 916, 923
R/utils.R                1       0  100.00%
TOTAL                 1836     101  94.50%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: b10975e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Unit Tests Summary

    1 files      4 suites   7s ⏱️
  28 tests   28 ✔️ 0 💤 0
212 runs  212 ✔️ 0 💤 0

Results for commit e08411d.

♻️ This comment has been updated with latest results.

@vedhav vedhav self-requested a review September 5, 2023 11:34
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 All four strategies max_deps_check, min_cohort_deps_check, min_isolated_deps_check, and release_deps_check yield 0 errors ✔ | 0 warnings ✔ | 0 notes ✔

@averissimo averissimo merged commit 76eac91 into main Sep 13, 2023
@averissimo averissimo deleted the verdepcheck_action branch September 13, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants