Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical metadata@main #165

Merged
merged 11 commits into from
Oct 24, 2024
Merged

Hierarchical metadata@main #165

merged 11 commits into from
Oct 24, 2024

Conversation

BFalquet
Copy link
Contributor

Add functions to combine rules or list of rules.

thank you for the review

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Unit Tests Summary

  1 files   13 suites   1s ⏱️
107 tests 104 ✅ 3 💤 0 ❌
350 runs  345 ✅ 5 💤 0 ❌

Results for commit 3d8fbb9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
rules 👶 $+0.01$ combine_list_rules_fails_as_expected_when_elements_are_not_rules
rules 👶 $+0.02$ combine_list_rules_works_as_expected
rules 👶 $+0.01$ combine_rules_fails_as_expected_when_both_rules_are_NULL_values
rules 👶 $+0.01$ combine_rules_works_as_expected
rules 👶 $+0.02$ combine_rules_works_as_expected_with_NULL_values

Results for commit 8d38359

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ---------
R/assertions.R            73       0  100.00%
R/co_relevels.R           17       0  100.00%
R/cut_by_group.R          15       0  100.00%
R/explicit_na.R           26       0  100.00%
R/filter.R                75       0  100.00%
R/join_adsub_adsl.R       92       8  91.30%   166-173
R/pivot.R                 59       0  100.00%
R/propagate.R             22       0  100.00%
R/reformat.R              80       0  100.00%
R/render_safe.R           55       1  98.18%   50
R/rules.R                 72       0  100.00%
R/unite.R                 31       0  100.00%
R/utils.R                 21       2  90.48%   72-73
R/zzz.R                    3       3  0.00%    4-6
TOTAL                    641      14  97.82%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/assertions.R           +19       0  +100.00%
R/filter.R                +2       0  +100.00%
R/join_adsub_adsl.R      +26       0  +3.43%
R/pivot.R                -14       0  +100.00%
R/reformat.R             +25       0  +100.00%
R/render_safe.R          +17       0  +0.81%
R/rules.R                +19      -1  +1.89%
R/utils.R                 -6      +2  -9.52%
TOTAL                    +88      +1  +0.17%

Results for commit: 3d8fbb9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

R/rules.R Outdated Show resolved Hide resolved
@BFalquet BFalquet requested a review from clarkliming October 18, 2024 05:51
NAMESPACE Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/rules.R Show resolved Hide resolved
R/rules.R Outdated Show resolved Hide resolved
R/rules.R Outdated Show resolved Hide resolved
@BFalquet BFalquet requested a review from clarkliming October 23, 2024 09:53
@BFalquet BFalquet mentioned this pull request Oct 23, 2024
31 tasks
R/rules.R Outdated Show resolved Hide resolved
R/rules.R Outdated Show resolved Hide resolved
Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@BFalquet BFalquet merged commit 5242f0d into main Oct 24, 2024
29 checks passed
@BFalquet BFalquet deleted the hierarchical_metadata@main branch October 24, 2024 07:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants