Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict tests; enhancements #145

Merged
merged 6 commits into from
Mar 1, 2024
Merged

strict tests; enhancements #145

merged 6 commits into from
Mar 1, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jan 24, 2024

Please review the changes carefully and let me know if there is something you don't like.

@pawelru pawelru marked this pull request as ready for review January 29, 2024 08:44
@pawelru pawelru requested a review from clarkliming as a code owner January 29, 2024 08:44
Copy link
Contributor

github-actions bot commented Jan 29, 2024

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ---------
R/assertions.R            73       0  100.00%
R/co_relevels.R           17       0  100.00%
R/cut_by_group.R          15       0  100.00%
R/explicit_na.R           26       0  100.00%
R/filter.R                73       0  100.00%
R/join_adsub_adsl.R       92       8  91.30%   166-173
R/pivot.R                 59       0  100.00%
R/propagate.R             22       0  100.00%
R/reformat.R              66       0  100.00%
R/render_safe.R           55       1  98.18%   50
R/rules.R                 53       1  98.11%   53
R/unite.R                 31       0  100.00%
R/utils.R                  8       0  100.00%
R/zzz.R                    3       3  0.00%    4-6
TOTAL                    593      13  97.81%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/assertions.R           +19       0  +100.00%
R/join_adsub_adsl.R      +26       0  +3.43%
R/pivot.R                -14       0  +100.00%
R/reformat.R             +11       0  +100.00%
R/render_safe.R          +17       0  +0.81%
R/utils.R                -19       0  +100.00%
TOTAL                    +40       0  +0.16%

Results for commit: 8c09de9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Unit Tests Summary

  1 files   13 suites   1s ⏱️
 97 tests  95 ✅ 2 💤 0 ❌
322 runs  319 ✅ 3 💤 0 ❌

Results for commit 8c09de9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@pawelru pawelru merged commit f6c6d86 into main Mar 1, 2024
24 checks passed
@pawelru pawelru deleted the strict_tests branch March 1, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants