-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace logo.png by logo.svg #800
Conversation
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
Code Coverage Summary
Diff against main
Results for commit: 2052f66 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 58 suites 3m 13s ⏱️ Results for commit 2052f66. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 9765124 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @llrs-roche
@@ -1,4 +1,4 @@ | |||
# `chevron`: Standard TLGs for clinical trials reporting <a href='https://insightsengineering.github.io/chevron/'><img src="man/figures/chevron.png" align="right" height="139" style="max-width: 100%; max-height: 139px;"/></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @llrs-roche this does not work and need a follow-up PR
https://github.com/insightsengineering/chevron?tab=readme-ov-file
It has to be changed to chevron.png
(or file renamed to logo.png
)
I just picked this repo randomly. Please double check other logo updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pavel! I think I missed renaming the file to logo.svg or maybe we are stuck with png for github to show the logo as usethis::use_logo
only uses PNG. I'll be checking this on all repos.
Pull Request
Replace the logo.png by logo.svg to reduce package's size (This is relevant for CRAN submissions were packages cannot be generally >5Mb of source code and get flagged for CRAN reviewer if they exceed this number).
Important: the logo appears to be different: there is some green pattern on the SVG that is not on other logo formats.
This package makes use of Github actions to check the branding, replaced there too.
Fixes insightsengineering/nestdevs-tasks#93