-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix listings tests@main #798
Conversation
I have read the CLA Document and I hereby sign the CLA 2 out of 3 committers have signed the CLA. |
Signed-off-by: b_falquet <[email protected]>
I have read the CLA Document and I hereby sign the CLA |
Unit Tests Summary 1 files 58 suites 2m 47s ⏱️ Results for commit 0254958. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit ed4930b ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @BFalquet , approve to unblock the merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @BFalquet , snapshot needs update
@shajoezhu I don't really get it, that is the snapshot i updated. Tests are passing on our server. |
can you try up version a few things formatters >= 0.5.9.9007 |
Code Coverage Summary
Diff against main
Results for commit: 0254958 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
@shajoezhu bumping dependencies version did the trick, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @BFalquet
Update snapshots following dependencies update.
Please check if this still fits you
thank you for the review