Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

756 replace scda by random.cdisc.data #760

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

BFalquet
Copy link
Contributor

#756

close #756

modified test to adapt to the new data.

thank you for the review

@BFalquet BFalquet requested a review from clarkliming as a code owner June 26, 2024 14:15
@BFalquet BFalquet requested a review from shajoezhu June 26, 2024 14:15
Copy link
Contributor

github-actions bot commented Jun 26, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------
R/ael01_nollt.R                  6       0  100.00%
R/ael02.R                       27       0  100.00%
R/ael03.R                       34       0  100.00%
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                       98       1  98.98%   172
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  93       7  92.47%   11-16, 123
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   124-129
R/lbt06.R                       70       0  100.00%
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       55       0  100.00%
R/mng01.R                       81       7  91.36%   83, 87-91, 153
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/report_null.R                 24       0  100.00%
R/rmpt01.R                      59      11  81.36%   88-97, 132
R/rmpt06.R                     134       3  97.76%   210-213
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              319      23  92.79%   51, 68, 119, 243, 264, 372-379, 446, 461-463, 465, 534-540, 550, 571
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   202-205
R/utils.R                      178      30  83.15%   122, 138, 157-159, 231-235, 276-279, 283-286, 313, 317, 329, 331, 343, 360-362, 384-397
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3351     112  96.66%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                -15      -1  +4.76%
R/ael02.R                      +27       0  +100.00%
R/ael03.R                      +34       0  +100.00%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                       +4       0  +0.04%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                  -6      +1  -1.47%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2      -3  +4.17%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -16       0  +100.00%
R/mng01.R                      -15      +6  -7.60%
R/pdt02.R                       -1       0  +100.00%
R/report_null.R                +24       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +19      +4  -0.88%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +94     +30  -16.85%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +280     +37  -0.90%

Results for commit: 4da587a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Unit Tests Summary

  1 files   56 suites   2m 49s ⏱️
255 tests 184 ✅  71 💤 0 ❌
503 runs  327 ✅ 176 💤 0 ❌

Results for commit 4da587a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Benoit :)))

@BFalquet BFalquet merged commit 6d3ccd3 into main Jul 1, 2024
29 checks passed
@BFalquet BFalquet deleted the 756-replace-scda-by-randomcdiscdata@main branch July 1, 2024 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace scda by random.cdisc.data
2 participants