Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cml02a_gl listing #753

Merged
merged 11 commits into from
Sep 11, 2024
Merged

cml02a_gl listing #753

merged 11 commits into from
Sep 11, 2024

Conversation

BFalquet
Copy link
Contributor

add listing and tests

thank you for the review.

@BFalquet BFalquet requested a review from clarkliming as a code owner May 29, 2024 11:58
Copy link
Contributor

github-actions bot commented May 29, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------
R/ael01_nollt.R                  6       0  100.00%
R/ael02.R                       27       0  100.00%
R/ael03.R                       34       0  100.00%
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                      104       5  95.19%   77-80, 183
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  93       7  92.47%   11-16, 123
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cml02a_gl.R                    8       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   124-129
R/lbt06.R                       70       0  100.00%
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       55       0  100.00%
R/mng01.R                       95      12  87.37%   86, 90-94, 126-130, 133, 175
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/report_null.R                 24       0  100.00%
R/rmpt01.R                      59      11  81.36%   88-97, 132
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              319      23  92.79%   51, 68, 119, 243, 264, 372-379, 446, 461-463, 465, 534-540, 550, 571
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   202-205
R/utils.R                      178      30  83.15%   123, 139, 158-160, 232-236, 277-280, 284-287, 314, 318, 330, 332, 344, 361-363, 385-398
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3379     121  96.42%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                -15      -1  +4.76%
R/ael02.R                      +27       0  +100.00%
R/ael03.R                      +34       0  +100.00%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                      +10      +4  -3.74%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                  -6      +1  -1.47%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cml02a_gl.R                   +8       0  +100.00%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2      -3  +4.17%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -16       0  +100.00%
R/mng01.R                       -1     +11  -11.59%
R/pdt02.R                       -1       0  +100.00%
R/report_null.R                +24       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +19      +4  -0.88%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +94     +30  -16.85%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +308     +46  -1.14%

Results for commit: 958db4b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   56 suites   2m 43s ⏱️
253 tests 182 ✅  71 💤 0 ❌
497 runs  318 ✅ 179 💤 0 ❌

Results for commit a37bfaa.

Copy link
Contributor

github-actions bot commented May 29, 2024

Unit Tests Summary

  1 files   57 suites   3m 23s ⏱️
280 tests 279 ✅ 1 💤 0 ❌
653 runs  644 ✅ 9 💤 0 ❌

Results for commit 958db4b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 29, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
aet04 💔 $4.28$ $+7.21$ $+8$ $-2$ $0$ $0$
chevron_tlg-methods 💔 $5.48$ $+2.66$ $+6$ $-10$ $0$ $0$
cml02a_gl 👶 $+0.52$ $+6$ $0$ $0$ $0$
coxt01 💔 $0.52$ $+1.49$ $+6$ $-1$ $0$ $0$
coxt02 💔 $0.65$ $+1.75$ $+6$ $-1$ $0$ $0$
rspt01 💔 $4.24$ $+3.60$ $+12$ $-7$ $0$ $0$
ttet01 💔 $3.01$ $+2.24$ $+6$ $-4$ $0$ $0$
utils 💔 $0.15$ $+2.31$ $+61$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
aet04 💔 $0.84$ $+1.26$ aet04_can_handle_NA_values
aet04 💔 $3.44$ $+5.96$ aet04_can_handle_some_NA_values
chevron_tlg-methods 💔 $1.06$ $+1.15$ script_funs_generates_a_valid_script
cml02a_gl 👶 $+0.19$ cml02a_gl_functions_work_as_expected
cml02a_gl 👶 $+0.19$ cml02a_gl_works_with_adcm_dataset
cml02a_gl 👶 $+0.14$ cml02a_gl_works_with_missing_data
coxt01 💔 $0.50$ $+1.50$ coxt01_can_handle_some_NA_values
coxt02 💔 $0.62$ $+1.76$ coxt02_can_handle_some_NA_values
utils 👶 $+0.01$ convert_to_month_warning_messages_as_expected
utils 👶 $+0.02$ convert_to_month_work_as_expected
utils 👶 $+0.02$ do_call_errors_as_expected
utils 👶 $+0.01$ do_call_work_as_expected
utils 👶 $+0.00$ droplevels.character_works_as_expected
utils 👶 $+0.03$ execute_with_args_works_as_expected
utils 👶 $+0.01$ expand_list_works
utils 👶 $+0.01$ format_date_works_as_expected_for_Date
utils 👶 $+0.01$ format_date_works_as_expected_for_POSIXct
utils 👶 $+0.01$ get_section_div_works
utils 👶 $+0.93$ gg_list_is_deprecated
utils 👶 $+0.02$ gg_theme_chevron_works_as_expected
utils 👶 $+0.96$ grob_list_is_deprecated
utils 👶 $+0.01$ lvls.character_works_as_expected
utils 👶 $+0.01$ lvls.default_works_as_expected
utils 👶 $+0.01$ lvls.factor_works_as_expected
utils 👶 $+0.01$ modify_character_works
utils 👶 $+0.01$ modify_default_args_works_as_expected
utils 👶 $+0.01$ quote_str_works_as_expected
utils 👶 $+0.02$ set_section_div_works

Results for commit ed33362

♻️ This comment has been updated with latest results.

@BFalquet BFalquet requested a review from clarkliming July 4, 2024 13:14
@BFalquet BFalquet requested a review from barnett11 September 4, 2024 13:37
@barnett11
Copy link
Contributor

Hi @BFalquet ,
When running listing with head or tail it works fine, but when running in its entirety I get below error?
Error in h(simpleError(msg, call)) : error in evaluating the argument 'x' in selecting a method for function 'toString': values must be length 1, but FUN(X[[1]]) result is length 0

@BFalquet
Copy link
Contributor Author

BFalquet commented Sep 9, 2024

Hi @BFalquet , When running listing with head or tail it works fine, but when running in its entirety I get below error? Error in h(simpleError(msg, call)) : error in evaluating the argument 'x' in selecting a method for function 'toString': values must be length 1, but FUN(X[[1]]) result is length 0

Sounds like an rlistings issue. Could you try to update formatters and rlistings (remotes::install_github("insightsengineering/rlistings"))

@BFalquet
Copy link
Contributor Author

BFalquet commented Sep 9, 2024

@Melkiades any idea ?

@Melkiades
Copy link
Contributor

Melkiades commented Sep 10, 2024

@Melkiades any idea ?

{} are dedicated characters for reference handling. We do not have added informative error to rlistings yet. Will attach fix to the issue below
insightsengineering/rlistings#225 (comment)

Copy link
Contributor

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @BFalquet ,
This looks perfect aside of the rlisting bug, the only suggestion I'd make is to not wrap the header as below, as this variable will always be the longest text and the header length is not a limiter here thanks,
image

@BFalquet
Copy link
Contributor Author

to not wrap the header as below, as this variable will always be the longest text and the header length is not a limiter here thanks,

Alright, line break has been removed

@BFalquet BFalquet requested a review from barnett11 September 11, 2024 09:15
Copy link
Contributor

@barnett11 barnett11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @BFalquet

@BFalquet BFalquet merged commit a252a81 into main Sep 11, 2024
30 checks passed
@BFalquet BFalquet deleted the cml02a_gl@main branch September 11, 2024 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants