-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cml02a_gl listing #753
cml02a_gl listing #753
Conversation
Code Coverage Summary
Diff against main
Results for commit: 958db4b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 56 suites 2m 43s ⏱️ Results for commit a37bfaa. |
Unit Tests Summary 1 files 57 suites 3m 23s ⏱️ Results for commit 958db4b. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit ed33362 ♻️ This comment has been updated with latest results. |
Hi @BFalquet , |
Sounds like an rlistings issue. Could you try to update |
@Melkiades any idea ? |
{} are dedicated characters for reference handling. We do not have added informative error to rlistings yet. Will attach fix to the issue below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @BFalquet ,
This looks perfect aside of the rlisting bug, the only suggestion I'd make is to not wrap the header as below, as this variable will always be the longest text and the header length is not a limiter here thanks,
Alright, line break has been removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks @BFalquet
add listing and tests
thank you for the review.