Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split listings #737

Merged
merged 8 commits into from
Apr 24, 2024
Merged

split listings #737

merged 8 commits into from
Apr 24, 2024

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented Apr 5, 2024 •
edited
Loading

close #738

additional arguments can be passed to the as_listing function in ael01_nollt which allows splitting by another variable. List of listings are returned as a rl_list object to be consistant with the logic developed for the plots (gg_list)

postprocessing handles rl_list object (list of listing)

thank you for the review

@BFalquet BFalquet requested a review from clarkliming as a code owner April 5, 2024 09:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ------------------------------------------------------------------------------
R/ael01_nollt.R                 25       2  92.00%   80-82
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                       98       1  98.98%   172
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  80       6  92.50%   11-16
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   124-129
R/lbt06.R                       70       3  95.71%   141-144
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       54       0  100.00%
R/mng01.R                       81       7  91.36%   83, 87-91, 153
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/rmpt01.R                      59      11  81.36%   88-97, 132
R/rmpt06.R                     134       3  97.76%   210-213
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              325      23  92.92%   51, 68, 119, 243, 264, 409-416, 483, 498-500, 502, 571-577, 587, 608
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   202-205
R/utils.R                      149      25  83.22%   116, 132, 151-153, 270-273, 277-280, 307, 311, 323, 325, 337, 354-356, 378-391
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3248     111  96.58%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                 +4      +1  -3.24%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                       +4       0  +0.04%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                 -19       0  -1.44%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2       0  -0.12%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -17       0  +100.00%
R/mng01.R                      -15      +6  -7.60%
R/pdt02.R                       -1       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +25      +4  -0.74%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +65     +25  -16.78%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +177     +36  -0.98%

Results for commit: bfd43d4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024 •
edited
Loading

Unit Tests Summary

  1 files   53 suites   2m 55s ⏱️
242 tests 172 ✅  70 💤 0 ❌
470 runs  301 ✅ 169 💤 0 ❌

Results for commit bfd43d4.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ael01_nollt 👶 $+0.18$ ael01_nollt_listing_can_be_split_by_an_additional_variable
ael01_nollt 👶 $+0.13$ split_ael01_nollt_listing_do_not_display_missing_values
utils 💀 $0.01$ $-0.01$ grob_list_works

Results for commit 702e29c

♻️ This comment has been updated with latest results.

@BFalquet BFalquet mentioned this pull request Apr 15, 2024
Closed
39 tasks
@BFalquet BFalquet requested a review from Melkiades April 15, 2024 07:33
clarkliming
clarkliming reviewed Apr 17, 2024
View reviewed changes
R/ael01_nollt.R Outdated Show resolved Hide resolved
clarkliming
clarkliming reviewed Apr 17, 2024
View reviewed changes
R/utils.R Outdated Show resolved Hide resolved
@BFalquet BFalquet requested a review from clarkliming April 18, 2024 15:54
clarkliming
clarkliming reviewed Apr 19, 2024
View reviewed changes
R/utils.R Outdated Show resolved Hide resolved
@BFalquet BFalquet requested a review from clarkliming April 19, 2024 12:33
@clarkliming
use list of objects (#741)
bfd43d4 
make minor modification on the program to allow simpler usage (use list
directly for listings, can this can already support list of rtables)

---------

Co-authored-by: benoit <[email protected]>
clarkliming
clarkliming approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thank you

@BFalquet BFalquet merged commit 2a8be96 into main Apr 24, 2024
25 checks passed
@BFalquet BFalquet deleted the 411-feature-export--decorate-list@main branch April 24, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkliming clarkliming clarkliming approved these changes

@Melkiades Melkiades Awaiting requested review from Melkiades

Assignees
No one assigned
Labels
chevron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] support list of listings
2 participants
@BFalquet @clarkliming