Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kmg01 usage after g_km refactor #733

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

edelarua
Copy link
Contributor

Closes #732

@edelarua edelarua added the sme label Mar 21, 2024
@edelarua edelarua requested a review from clarkliming as a code owner March 21, 2024 22:31
Copy link
Contributor

github-actions bot commented Mar 21, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------
R/ael01_nollt.R                 21       1  95.24%   75
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                       98       1  98.98%   172
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  80       6  92.50%   11-16
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       28       0  100.00%
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   124-129
R/lbt06.R                       70       3  95.71%   141-144
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       54       0  100.00%
R/mng01.R                       82       7  91.46%   83, 87-91, 154
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/rmpt01.R                      59      11  81.36%   88-97, 132
R/rmpt06.R                     134       3  97.76%   210-213
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              325      23  92.92%   51, 68, 119, 243, 264, 409-416, 483, 498-500, 502, 571-577, 587, 608
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   202-205
R/utils.R                      157      21  86.62%   142, 158, 177-179, 296-299, 303-306, 333, 337, 349, 351, 363, 380-382
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3246     100  96.92%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                       +4       0  +0.04%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                 -19       0  -1.44%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       -1       0  +100.00%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2       0  -0.12%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -17       0  +100.00%
R/mng01.R                      -14      +6  -7.49%
R/pdt02.R                       -1       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +25      +4  -0.74%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +73     +21  -13.38%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +175     +25  -0.64%

Results for commit: 5301630

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 21, 2024

Unit Tests Summary

  1 files   53 suites   2m 58s ⏱️
241 tests 171 ✅  70 💤 0 ❌
468 runs  302 ✅ 166 💤 0 ❌

Results for commit 5301630.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 21, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
kmg01 💔 $2.46$ $+1.46$ $0$ $0$ $0$ $0$
mng01 💔 $15.17$ $+1.28$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
kmg01 👶 $+0.52$ kmg01_works_for_stratified_analysis
kmg01 💀 $0.38$ $-0.38$ kmg01_works_for_stratified_anlaysis

Results for commit c0607a5

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Emily ;)

@Melkiades Melkiades requested a review from BFalquet March 22, 2024 08:47
@edelarua edelarua merged commit ea95ca8 into main Mar 22, 2024
24 checks passed
@edelarua edelarua deleted the 732_g_km_refactor@main branch March 22, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates after g_km refactor
2 participants