[skip vbump] prepare for CRAN release #713

clarkliming · 2023-12-13T23:57:16Z

No description provided.

github-actions · 2023-12-15T10:50:46Z

Unit Tests Summary

1 files 53 suites 2m 39s ⏱️
240 tests 160 ✅ 70 💤 4 ❌ 6 🔥
489 runs 311 ✅ 166 💤 6 ❌ 6 🔥

For more details on these failures and errors, see this check.

Results for commit 1bc0e77.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-15T11:02:52Z

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------
R/ael01_nollt.R                 21       1  95.24%   75
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                       98       1  98.98%   172
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  80       6  92.50%   11-16
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       37       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   51
R/fstg01.R                      44       0  100.00%
R/fstg02.R                      49       0  100.00%
R/kmg01.R                       29       0  100.00%
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   124-129
R/lbt06.R                       70       3  95.71%   141-144
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       54       0  100.00%
R/mng01.R                       82       9  89.02%   83, 87-91, 111-112, 154
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/rmpt01.R                      59      11  81.36%   88-97, 132
R/rmpt06.R                     134       3  97.76%   210-213
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              325      23  92.92%   51, 68, 119, 243, 264, 409-416, 483, 498-500, 502, 571-577, 587, 608
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   202-205
R/utils.R                      157      21  86.62%   142, 158, 177-179, 296-299, 303-306, 333, 337, 349, 351, 363, 380-382
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3248     102  96.86%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                       +4       0  +0.04%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                 -19       0  -1.44%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +8       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -6       0  +100.00%
R/fstg02.R                      -6       0  +100.00%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2       0  -0.12%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -17       0  +100.00%
R/mng01.R                      -14      +8  -9.93%
R/pdt02.R                       -1       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +25      +4  -0.74%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +73     +21  -13.38%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +177     +27  -0.70%

Results for commit: 7a4a00c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

github-actions · 2023-12-18T10:22:37Z

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
chevron_tlg-methods	💚	$10.58$	$-4.98$	$0$	$0$	$0$	$0$
default_tlg	💚	$12.39$	$-1.08$	$0$	$0$	$0$	$0$
fstg02	💚	$8.96$	$-3.62$	$+12$	$0$	$0$	$+5$
lbt14	💚	$30.22$	$-22.50$	$0$	$0$	$0$	$0$
vst01	💚	$14.73$	$-1.02$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
chevron_tlg-methods	💚	$3.84$	$-2.09$	run_works_as_expected_for_chevron_t_object
chevron_tlg-methods	💚	$2.34$	$-1.15$	script_funs_generates_a_valid_script
fstg01	👶		$+1.77$	fstg01_works_if_changes_are_in_subgroups_conf_level_and_label_all
fstg01	💀	$0.99$	$-0.99$	fstg01_works_if_changes_are_in_subgroups_strata_var_conf_level_and_label_all
fstg02	💚	$2.70$	$-1.49$	fstg02_can_handle_customized_time_units
fstg02	💚	$2.59$	$-1.39$	fstg02_works_as_expected_with_custom_color_set
lbt14	💚	$5.18$	$-3.80$	lbt14_can_accept_different_gr_missing
lbt14	💚	$5.39$	$-4.09$	lbt14_can_accept_different_gr_missing_with_direction_high
lbt14	💚	$1.62$	$-1.12$	lbt14_can_handle_all_NA_values
lbt14	💚	$1.52$	$-1.03$	lbt14_can_handle_all_NA_values_with_direction_high
lbt14	💚	$2.97$	$-2.22$	lbt14_can_handle_some_NA_values
lbt14	💚	$2.93$	$-2.23$	lbt14_can_handle_some_NA_values_with_direction_high
lbt14	💚	$2.65$	$-1.98$	lbt14_functions_with_default_argument_value_return_expected_result_with_test_data
lbt14	💚	$2.81$	$-2.18$	lbt14_functions_with_default_argument_value_return_expected_result_with_test_data_when_direction_high
lbt14	💚	$2.50$	$-1.89$	lbt14_functions_with_gr_missing_excl_return_expected_result_with_test_data
lbt14	💚	$2.57$	$-1.96$	lbt14_functions_with_gr_missing_gr_0_return_expected_result_with_test_data

Results for commit 8740174

♻️ This comment has been updated with latest results.

Signed-off-by: b_falquet <[email protected]>

BFalquet

Thank you, ready for submission

Signed-off-by: Liming <[email protected]>

BFalquet · 2023-12-19T07:30:00Z

I think we need to remove the "Remotes" field again.

DESCRIPTION

shajoezhu · 2023-12-20T04:33:35Z

I think we need to remove the "Remotes" field again.

since everything is now open-source, do you need "remotes" field ever again?

clarkliming · 2023-12-20T04:43:48Z

I think we need to remove the "Remotes" field again.

since everything is now open-source, do you need "remotes" field ever again?

yes I think we can remove it forever

joe's suggestion Co-authored-by: Joe Zhu <[email protected]> Signed-off-by: b_falquet <[email protected]>

Signed-off-by: Liming <[email protected]>

BFalquet

minor comment

DESCRIPTION

clarkliming · 2024-01-30T07:28:30Z

@BFalquet I reduce the size of our test data, leading to all the snapshot changes. (it can be further reduced, if needed)

However this should not be critical (as no functionality is updated)

BFalquet

The tests for lbt14 and chevron-methods were still a bit slow (~30sec), I trimmed the data in the initial part of the test to speed up the execution to ~15sec locally. rspt01 snapshot tests were failing but it could be a rounding error, I commit this change separately. Note, tests were performed with the CRAN version of formatters, rlistings, rtables, tern and dunlin.

tern_0.9.3, rlistings_0.2.7, rtables_0.6.6, formatters_0.5.5

prepare for CRAN release

9264fa1

clarkliming changed the title ~~prepare for CRAN release~~ [skip vbump] prepare for CRAN release Dec 13, 2023

clarkliming and others added 3 commits December 13, 2023 23:58

update news

a66c0e8

add @returns

743f131

document object

b11bde3

typo

4281ef6

benoit and others added 2 commits December 15, 2023 14:26

correct doc error

2cdbd7a

Merge branch 'main' into pre_cran

f74a4ac

Merge branch 'main' into pre_cran

cc69894

Signed-off-by: b_falquet <[email protected]>

BFalquet self-requested a review December 18, 2023 12:13

BFalquet approved these changes Dec 18, 2023

View reviewed changes

clarkliming and others added 2 commits December 18, 2023 12:16

clean up argument in rd

fe0de13

Merge branch 'main' into pre_cran

7a4a00c

Signed-off-by: Liming <[email protected]>

shajoezhu reviewed Dec 20, 2023

View reviewed changes

DESCRIPTION Outdated Show resolved Hide resolved

BFalquet and others added 5 commits December 20, 2023 08:59

Update DESCRIPTION

f68309f

joe's suggestion Co-authored-by: Joe Zhu <[email protected]> Signed-off-by: b_falquet <[email protected]>

remove remotes

c88c0b8

Update rlisting version

72f9ed7

Signed-off-by: Liming <[email protected]>

add more details in description

e575c5a

fix spelling

03c7b93

BFalquet reviewed Jan 17, 2024

View reviewed changes

DESCRIPTION Outdated Show resolved Hide resolved

clarkliming added 4 commits January 18, 2024 02:26

trim data

79f69b8

update docs

4bb3519

update description

b25e8d9

reduce syn data size

42f4ad6

update description

f67cdd0

benoit added 2 commits January 30, 2024 10:38

reduce test length

20c502a

fix snapshots rspt01

6f1edd2

BFalquet approved these changes Jan 30, 2024

View reviewed changes

benoit added 4 commits January 30, 2024 17:57

modify adrs AVALC to distribute among arms

0990bd9

update example

8d090df

Remove Config/Needs field

c524eb1

add back Remotes and Config/Need

1bc0e77

BFalquet merged commit efe8d8f into main Feb 1, 2024
20 of 22 checks passed

BFalquet deleted the pre_cran branch February 1, 2024 09:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[skip vbump] prepare for CRAN release #713

[skip vbump] prepare for CRAN release #713

clarkliming commented Dec 13, 2023

github-actions bot commented Dec 15, 2023 •

edited

Loading

github-actions bot commented Dec 15, 2023 •

edited

Loading

github-actions bot commented Dec 18, 2023 •

edited

Loading

BFalquet left a comment

BFalquet commented Dec 19, 2023

shajoezhu commented Dec 20, 2023

clarkliming commented Dec 20, 2023

BFalquet left a comment

clarkliming commented Jan 30, 2024

BFalquet left a comment

[skip vbump] prepare for CRAN release #713

[skip vbump] prepare for CRAN release #713

Conversation

clarkliming commented Dec 13, 2023

github-actions bot commented Dec 15, 2023 • edited Loading

Unit Tests Summary

github-actions bot commented Dec 15, 2023 • edited Loading

Code Coverage Summary

Diff against main

github-actions bot commented Dec 18, 2023 • edited Loading

Unit Test Performance Difference

BFalquet left a comment

Choose a reason for hiding this comment

BFalquet commented Dec 19, 2023

shajoezhu commented Dec 20, 2023

clarkliming commented Dec 20, 2023

BFalquet left a comment

Choose a reason for hiding this comment

clarkliming commented Jan 30, 2024

BFalquet left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 15, 2023 •

edited

Loading

github-actions bot commented Dec 15, 2023 •

edited

Loading

github-actions bot commented Dec 18, 2023 •

edited

Loading